Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add arm64 support for GCE node configuration #99242

Merged
merged 1 commit into from Feb 20, 2021
Merged

Add arm64 support for GCE node configuration #99242

merged 1 commit into from Feb 20, 2021

Conversation

liu-cong
Copy link
Contributor

@liu-cong liu-cong commented Feb 19, 2021 •
edited

What type of PR is this?

/kind feature

sig/cloud-provider

What this PR does / why we need it:

This PR allows installing arm64 release artifacts for node

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

This change should be backwards compatible with amd64 nodes.

Does this PR introduce a user-facing change?

Added support for installing arm64 node artifacts.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Testing

I tested this in a amd64 GCE VM as well as a GCE VM running arm64 emulator in QEMU.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 19, 2021
@k8s-ci-robot
Copy link
Contributor

@liu-cong: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/provider/gcp Issues or PRs related to gcp provider labels Feb 19, 2021
@k8s-ci-robot k8s-ci-robot added sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 19, 2021
@liu-cong
Copy link
Contributor Author

/assign sarandia
/assign ljfh001

@k8s-ci-robot
Copy link
Contributor

@liu-cong: GitHub didn't allow me to assign the following users: sarandia, ljfh001.

Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign sarandia
/assign ljfh001

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ljfh001
ljfh001 reviewed Feb 19, 2021
View reviewed changes
cluster/addons/kube-proxy/kube-proxy-ds.yaml Show resolved Hide resolved
cluster/gce/gci/configure-helper.sh Outdated Show resolved Hide resolved
cluster/gce/gci/configure.sh Outdated Show resolved Hide resolved
sarandia
sarandia approved these changes Feb 19, 2021
View reviewed changes
Copy link
Contributor

@sarandia sarandia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ljfh001
Copy link

ljfh001 commented Feb 19, 2021

/lgtm

@k8s-ci-robot
Copy link
Contributor

@ljfh001: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yguo0905
Copy link
Contributor

/approve

@liu-cong
Copy link
Contributor Author

/retest

MrHohn
MrHohn approved these changes Feb 19, 2021
View reviewed changes
Copy link
Member

@MrHohn MrHohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/aprove

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 19, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liu-cong, ljfh001, MrHohn, sarandia, yguo0905

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2021
@liu-cong
Copy link
Contributor Author

/retest

@liu-cong
Copy link
Contributor Author

/test pull-kubernetes-e2e-kind-ipv6

@liu-cong
Copy link
Contributor Author

/test pull-kubernetes-e2e-kind

@k8s-ci-robot k8s-ci-robot merged commit b6e4c1c into kubernetes:master Feb 20, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Feb 20, 2021
@liu-cong
Copy link
Contributor Author

Are there any architectures that are still not supported? or is there a subset of ones that are and the rest still are not?

This PR is just to enable the script to pull arm64 binaries instead of hard-coded amd64. No new architectures were added.

@SataQiu SataQiu mentioned this pull request Jul 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljfh001 ljfh001 ljfh001 approved these changes

@MrHohn MrHohn MrHohn approved these changes

@sarandia sarandia sarandia approved these changes

@bowei bowei Awaiting requested review from bowei

@karan karan Awaiting requested review from karan

Assignees

@MrHohn MrHohn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@liu-cong @k8s-ci-robot @ljfh001 @yguo0905 @MushuEE @MrHohn @sarandia