Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote Read, Replace and Patch ReplicaSetScale test to Conformance +3 endpoints #99282

Merged
merged 1 commit into from Feb 23, 2021
Merged

Promote Read, Replace and Patch ReplicaSetScale test to Conformance +3 endpoints #99282

merged 1 commit into from Feb 23, 2021

Conversation

Riaankl
Copy link
Contributor

@Riaankl Riaankl commented Feb 21, 2021 •
edited

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This PR adds a test to test the following untested endpoints:

  • replaceAppsV1NamespacedReplicaSetScale
  • readAppsV1NamespacedReplicaSetScale
  • patchAppsV1NamespacedReplicaSetScale

Which issue(s) this PR fixes:
Fixes #98920

Testgrid Link:
Testgrid

Special notes for your reviewer:
Adds +3 endpoint test coverage (good for conformance)

Does this PR introduce a user-facing change?:

NONE

Release note:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

/sig testing
/sig architecture
/sig apps
/area conformance

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/apps Categorizes an issue or PR as relevant to SIG Apps. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/conformance Issues or PRs related to kubernetes conformance tests needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/test labels Feb 21, 2021
@Riaankl Riaankl mentioned this pull request Feb 21, 2021
Closed
6 tasks
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 21, 2021
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 21, 2021
@Riaankl
Copy link
Contributor Author

Riaankl commented Feb 21, 2021

/test pull-kubernetes-e2e-kind
Unrelated flake

1/5726 Tests Failed. | expand_less
-- | --
Kubernetes e2e suite: [sig-apps] Deployment should run the lifecycle of a Deployment [Conformance] expand_less1m4stest/e2e/framework/framework.go:640 Feb 21 15:33:32.439: 
failed to see replicas of test-deployment in namespace deployment-1355 scale to requested 
amount of 2 Unexpected error:     <*errors.errorString \| 0xc00023e240>: 
{         s: "timed out waiting for the condition",     }     timed out waiting for the condition occurred test/e2e/apps/deployment.go:252open stdoutopen_in_new | Kubernetes e2e suite: 
[sig-apps] Deployment should run the lifecycle of a Deployment [Conformance] expand_less | 1m4s | test/e2e/framework/framework.go:640 Feb 21 15:33:32.439: failed to see replicas of test-deployment 
in namespace deployment-1355 scale to requested amount of 2 Unexpected error:    
 <*errors.errorString \| 0xc00023e240>: {         s: "timed out waiting for the condition",     }     
timed out waiting for the condition occurred test/e2e/apps/deployment.go:252open stdoutopen_in_new
Kubernetes e2e suite: [sig-apps] Deployment should run the lifecycle of a Deployment [Conformance] 
expand_less | 1m4s
test/e2e/framework/framework.go:640 Feb 21 15:33:32.439: failed to see replicas of test-deployment in namespace deployment-1355 scale to requested amount of 2 Unexpected error:     
<*errors.errorString \| 0xc00023e240>: {         s: "timed out waiting for the condition",     }     timed out waiting for the condition occurred test/e2e/apps/deployment.go:252open stdoutopen_in_new

@Riaankl
Copy link
Contributor Author

Riaankl commented Feb 21, 2021 •
edited

/test pull-kubernetes-e2e-kind

Unrelated network & storage flakes

Kubernetes e2e suite: [sig-storage] PersistentVolumes-local [Volume type: dir] One pod requesting one prebound PVC should be able to mount volume and write from pod1 expand_more2m28s | Kubernetes e2e suite: [sig-storage] PersistentVolumes-local [Volume type: dir] One pod requesting one prebound PVC should be able to mount volume and write from pod1 expand_more | 2m28s
-- | -- | --
Kubernetes e2e suite: [sig-storage] PersistentVolumes-local [Volume type: dir] One pod requesting one prebound PVC should be able to mount volume and write from pod1 expand_more | 2m28s
Kubernetes e2e suite: [sig-storage] PersistentVolumes-local [Volume type: dir-link] Two pods mounting a local volume at the same time should be able to write from pod1 and read from pod2 expand_more2m35s | Kubernetes e2e suite: [sig-storage] PersistentVolumes-local [Volume type: dir-link] Two pods mounting a local volume at the same time should be able to write from pod1 and read from pod2 expand_more | 2m35s
Kubernetes e2e suite: [sig-storage] PersistentVolumes-local [Volume type: dir-link] Two pods mounting a local volume at the same time should be able to write from pod1 and read from pod2 expand_more | 2m35s
Kubernetes e2e suite: [sig-storage] PersistentVolumes-local [Volume type: blockfswithformat] One pod requesting one prebound PVC should be able to mount volume and read from pod1 expand_more2m7s | Kubernetes e2e suite: [sig-storage] PersistentVolumes-local [Volume type: blockfswithformat] One pod requesting one prebound PVC should be able to mount volume and read from pod1 expand_more | 2m7s
Kubernetes e2e suite: [sig-storage] PersistentVolumes-local [Volume type: blockfswithformat] One pod requesting one prebound PVC should be able to mount volume and read from pod1 expand_more | 2m7s
Kubernetes e2e suite: [sig-network] Services should serve multiport endpoints from pods [Conformance] expand_more5m5s | Kubernetes e2e suite: [sig-network] Services should serve multiport endpoints from pods [Conformance] expand_more | 5m5s
Kubernetes e2e suite: [sig-network] Services should serve multiport endpoints from pods [Conformance] expand_more | 5m5s
Kubernetes e2e suite: [k8s.io] [sig-node] kubelet [k8s.io] [sig-node] Clean up pods on node kubelet should be able to delete 10 pods per node in 1m0s. expand_more5m43s | Kubernetes e2e suite: [k8s.io] [sig-node] kubelet [k8s.io] [sig-node] Clean up pods on node kubelet should be able to delete 10 pods per node in 1m0s. expand_more | 5m43s
Kubernetes e2e suite: [k8s.io] [sig-node] kubelet [k8s.io] [sig-node] Clean up pods on node kubelet should be able to delete 10 pods per node in 1m0s. expand_more | 5m43s
Kubernetes e2e suite: [sig-network] Services should implement service.kubernetes.io/headless expand_more5m56s | Kubernetes e2e suite: [sig-network] Services should implement service.kubernetes.io/headless expand_more | 5m56s
Kubernetes e2e suite: [sig-network] Services should implement service.kubernetes.io/headless expand_more | 5m56s
Kubernetes e2e suite: [sig-storage] PersistentVolumes-local [Volume type: block] Two pods mounting a local volume one after the other should be able to write from pod1 and read from pod2 expand_more2m12s | Kubernetes e2e suite: [sig-storage] PersistentVolumes-local [Volume type: block] Two pods mounting a local volume one after the other should be able to write from pod1 and read from pod2 expand_more | 2m12s
Kubernetes e2e suite: [sig-storage] PersistentVolumes-local [Volume type: block] Two pods mounting a local volume one after the other should be able to write from pod1 and read from pod2 expand_more | 2m12s
Kubernetes e2e suite: [sig-storage] PersistentVolumes-local [Volume type: blockfswithoutformat] Two pods mounting a local volume one after the other should be able to write from pod1 and read from pod2 expand_more | Kubernetes e2e suite: [sig-storage] PersistentVolumes-local [Volume type: blockfswithoutformat] Two pods mounting a local volume one after the other should be able to write from pod1 and read from pod2 expand_more
Kubernetes e2e suite: [sig-storage] PersistentVolumes-local [Volume type: blockfswithoutformat] Two pods mounting a local volume one after the other should be able to write from pod1 and read from pod2 expand_more

@Riaankl
Copy link
Contributor Author

Riaankl commented Feb 21, 2021

/test pull-kubernetes-e2e-kind

Unrelated storage test flake

• Failure [152.570 seconds]
[sig-storage] PersistentVolumes-local 
test/e2e/storage/utils/framework.go:23
  [Volume type: dir-link]
  test/e2e/storage/persistent_volumes-local.go:191
    Two pods mounting a local volume at the same time
    test/e2e/storage/persistent_volumes-local.go:247
      should be able to write from pod1 and read from pod2 [It]
      test/e2e/storage/persistent_volumes-local.go:248
      Feb 21 16:50:51.885: Unexpected error:

@dims
Copy link
Member

dims commented Feb 21, 2021

/assign @janetkuo @kow3ns @mattfarina @prydonius

Dear sig-app chairs, please sign off!

@Riaankl
Copy link
Contributor Author

Riaankl commented Feb 21, 2021

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 21, 2021
@Riaankl Riaankl added this to Promotion PRs Needing Approval in conformance-definition Feb 21, 2021
@soltysh
Copy link
Contributor

soltysh commented Feb 22, 2021

Dear sig-app chairs, please sign off!

Looking...

soltysh
soltysh approved these changes Feb 22, 2021
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 22, 2021
@dims
Copy link
Member

dims commented Feb 22, 2021

/approve
/lgtm

@spiffxp @johnbelamaric this passes the bar i think for promotion, please look.

spiffxp
spiffxp approved these changes Feb 23, 2021
View reviewed changes
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, Riaankl, soltysh, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 23, 2021
@k8s-ci-robot k8s-ci-robot merged commit 462dbc1 into kubernetes:master Feb 23, 2021
conformance-definition automation moved this from Promotion PRs Needing Approval to Done Feb 23, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spiffxp spiffxp spiffxp approved these changes

@soltysh soltysh soltysh approved these changes

@johnbelamaric johnbelamaric Awaiting requested review from johnbelamaric

Assignees

@dims dims

@spiffxp spiffxp

@mattfarina mattfarina

@soltysh soltysh

@prydonius prydonius

@janetkuo janetkuo

@kow3ns kow3ns

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance Issues or PRs related to kubernetes conformance tests area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
conformance-definition
  
Done
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

Write Read, Replace and Patch ReplicaSetScale test +3 endpoints
9 participants
@Riaankl @dims @soltysh @k8s-ci-robot @spiffxp @mattfarina @prydonius @janetkuo @kow3ns