Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

promote RootCAConfigMap e2e test to Conformance #99316

Merged
merged 1 commit into from Feb 23, 2021
Merged

promote RootCAConfigMap e2e test to Conformance #99316

merged 1 commit into from Feb 23, 2021

Conversation

zshihang
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

meet criteria for graduating RootCAConfigMap GA

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-auth/1205-bound-service-account-tokens

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 22, 2021
@k8s-ci-robot k8s-ci-robot added area/test sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 22, 2021
@zshihang
Copy link
Contributor Author

/priority important-soon
/triage accepted
/cc @liggitt

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 22, 2021
@zshihang
Copy link
Contributor Author

/area conformance
/cc @kubernetes/sig-architecture-pr-reviews @kubernetes/sig-auth-pr-reviews @kubernetes/cncf-conformance-wg

@liggitt
Copy link
Member

liggitt commented Feb 22, 2021

can you link to the testgrid showing the existing periodic e2e test runs to verify 2 weeks of non-flaky behavior?

@liggitt
Copy link
Member

liggitt commented Feb 22, 2021

/lgtm
/approve
/hold for testgrid link and conformance review

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 22, 2021
@zshihang
Copy link
Contributor Author

https://testgrid.k8s.io/sig-auth-gce#gce&width=5&include-filter-by-regex=%20kube-root-ca.crt

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 22, 2021
@dims
Copy link
Member

dims commented Feb 22, 2021

/retest
/approve
/lgtm

@spiffxp @johnbelamaric this PR qualifies to be promoted. please take a look.

@zshihang zshihang mentioned this pull request Feb 23, 2021
Merged
@zshihang
Copy link
Contributor Author

/retest

spiffxp
spiffxp approved these changes Feb 23, 2021
View reviewed changes
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 23, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, liggitt, spiffxp, zshihang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 23, 2021
@spiffxp spiffxp added this to Promotion PRs Needing Approval in conformance-definition Feb 23, 2021
@k8s-ci-robot k8s-ci-robot merged commit 1db189e into kubernetes:master Feb 23, 2021
conformance-definition automation moved this from Promotion PRs Needing Approval to Done Feb 23, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Feb 23, 2021
@liggitt liggitt moved this from In progress to 1.21 - Done in SIG-Auth: Projected Service Account Tokens Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spiffxp spiffxp spiffxp approved these changes

@dims dims Awaiting requested review from dims

@mikedanese mikedanese Awaiting requested review from mikedanese

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@dims dims

@spiffxp spiffxp

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance Issues or PRs related to kubernetes conformance tests area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG-Auth: Projected Service Account T...
1.21 - Done
conformance-definition
  
Done
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@zshihang @liggitt @dims @k8s-ci-robot @spiffxp