Switch gitVersion format to non-abbreviated hash

[liggitt]

What type of PR is this?

/kind bug

Which issue(s) this PR fixes:

Fixes #99376

Ensures that source archives for a given sha/tag remain consistent over time, even if sha collisions require the abbreviated hash to grow in the future.

Does this PR introduce a user-facing change?

NONE

Not really sure who to target this at, but maybe @kubernetes/sig-release for review? The artifacts we build don't even make use of the git archive mechanism, and our binaries override the variable using build flags.

[BenTheElder]

Are we going to have surprises when this doesn't match the version in other aspects of the build?

[hasheddan]

/triage accepted
/sig release

[liggitt]

Are we going to have surprises when this doesn't match the version in other aspects of the build?

it already doesn't... the build pins to a 14-character abbreviated hash:

kubernetes/hack/lib/version.sh

Lines 68 to 69 in 9d7d3eb

	# Use git describe to find the version based on tags.
	if [[ -n ${KUBE_GIT_VERSION-} ]] || KUBE_GIT_VERSION=$("${git[@]}" describe --tags --match='v*' --abbrev=14 "${KUBE_GIT_COMMIT}^{commit}" 2>/dev/null); then

[liggitt]

ha, and the build script bit which does honor git archive substitution was already using %H:

kubernetes/hack/lib/version.sh

Lines 40 to 54 in 9d7d3eb

	# If the kubernetes source was exported through git archive, then
	# we likely don't have a git tree, but these magic values may be filled in.
	# shellcheck disable=SC2016,SC2050
	# Disabled as we're not expanding these at runtime, but rather expecting
	# that another tool may have expanded these and rewritten the source (!)
	if [[ '$Format:%%$' == "%" ]]; then
	KUBE_GIT_COMMIT='$Format:%H$'
	KUBE_GIT_TREE_STATE="archive"
	# When a 'git archive' is exported, the '$Format:%D$' below will look
	# something like 'HEAD -> release-1.8, tag: v1.8.3' where then 'tag: '
	# can be extracted from it.
	if [[ '$Format:%D$' =~ tag:\ (v[^ ,]+) ]]; then
	KUBE_GIT_VERSION="${BASH_REMATCH[1]}"
	fi
	fi

[BenTheElder]

we're hitting I/O throttling in CI again, xref: kubernetes/test-infra#20966 (comment)
/retest

[BenTheElder]

/hold
(for others to review)

[hasheddan]

/lgtm
/cc @justaugustus @saschagrunert

[liggitt]

/retest

[spiffxp]

/test pull-kubernetes-e2e-kind

[liggitt]

plan to unhold tomorrow if there are no other comments

[dims]

/approve
/lgtm

sounds like a plan @liggitt

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, dims, hasheddan, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• staging/src/k8s.io/client-go/OWNERS [liggitt]
• staging/src/k8s.io/component-base/OWNERS [liggitt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[liggitt]

/hold cancel