New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup: wrap the apiserver identity validation #99573
cleanup: wrap the apiserver identity validation #99573
Conversation
/assign @caesarxuchao |
@@ -150,6 +150,19 @@ func validateAPIPriorityAndFairness(options *ServerRunOptions) []error { | |||
return nil | |||
} | |||
|
|||
func validateAPIServerIdentity(options *ServerRunOptions) []error { | |||
var errs []error | |||
if utilfeature.DefaultFeatureGate.Enabled(genericfeatures.APIServerIdentity) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's unnecessary to check the feature gate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two flags valid when the feature gate enabled, so i add the logic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
49f08ef
to
c7bf550
Compare
/retest |
1 similar comment
/retest |
/test pull-kubernetes-unit |
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: caesarxuchao, pandaamanda The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: