New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dougsland and rikatz as sig-cli reviewers #99666
Add dougsland and rikatz as sig-cli reviewers #99666
Conversation
@eddiezane: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/sig cli |
@eddiezane @soltysh and the rest of sig-cli folks, I would like to thank you very much for the trust :) |
I say the same guys, Thank you for the trust. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/assign @thockin
for top-level approve
Congrats to both of you 🎉 |
/lgtm |
/approve
…On Wed, Mar 3, 2021 at 8:01 AM Kubernetes Prow Robot < ***@***.***> wrote:
[APPROVALNOTIFIER] This PR is *NOT APPROVED*
This pull-request has been approved by: *eddiezane
<#99666#>*, *pwittrock
<#99666 (comment)>*,
*soltysh
<#99666 (review)>*
To complete the pull request process
<https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process>,
please assign *thockin* after the PR has been reviewed.
You can assign the PR to them by writing /assign @thockin in a comment
when ready.
The full list of commands accepted by this bot can be found here
<https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes>.
Needs approval from an approver in each of these files:
- *OWNERS
<https://github.com/kubernetes/kubernetes/blob/master/OWNERS>*
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#99666 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABKWAVBBRI7WK5TZV44G3KTTBZMMJANCNFSM4YQCXSPA>
.
|
/test pull-kubernetes-dependencies |
Signed-off-by: Eddie Zaneski <eddiezane@gmail.com>
aea0cd9
to
71b33d5
Compare
Failures were due to the 1.16 migration. Had to rebase. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eddiezane, pwittrock, seans3, soltysh, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-kubernetes-e2e-kind-ipv6 |
/hold |
/hold cancel |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
This PR adds @dougsland and @rikatz as sig-cli reviewers.
Doug and Ricardo have been stepping up and helping out a ton with reviews. We're thankful to have them in the community.
Special notes for your reviewer:
/cc @soltysh @seans3 @pwittrock
Does this PR introduce a user-facing change?