Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update cluster/dns/coredns to 1.8.0 as kubeadm #99752

Merged
merged 1 commit into from Mar 8, 2021

Conversation

pacoxu
Copy link
Member

@pacoxu pacoxu commented Mar 4, 2021

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

#96429 use 1.8.0 in kubeadm of 1.21
So I think we should upgrade the coredns image here as well.

Which issue(s) this PR fixes:

part of #99751

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 4, 2021
@k8s-ci-robot
Copy link
Contributor

@pacoxu: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 4, 2021
@k8s-ci-robot k8s-ci-robot added area/provider/gcp Issues or PRs related to gcp provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 4, 2021
@BenTheElder
Copy link
Member

/home/prow/go/src/k8s.io/kubernetes
INFO Validating zeitgeist options...              
ERRO /home/prow/go/src/k8s.io/kubernetes/build/dependencies.yaml indicates that coredns-kube-up should be at version 1.7.0, but the following files didn't match: cluster/addons/dns/coredns/coredns.yaml.base, cluster/addons/dns/coredns/coredns.yaml.in, cluster/addons/dns/coredns/coredns.yaml.sed 
FATA Dependencies are not in sync                 
+++ exit code: 1
+++ error: 1
FAILED   verify-external-dependencies-version.sh	40s
Verifying verify-vendor-licenses.sh

it's expected that kube-up and kubeadm are both updated for better coverage in CI

@pacoxu
Copy link
Member Author

pacoxu commented Mar 4, 2021

@BenTheElder I updated the coredns-kube-up part.

kubeadm has already used 1.8.0.

for new released 1.8.3, I may work on the corefile-migration first.

@rajansandeep
Copy link
Contributor

Hi @pacoxu, thank you for picking this up.
Can you also update the corefile-migration tool to v1.0.11 in https://github.com/kubernetes/kubernetes/blob/master/cluster/gce/upgrade.sh#L485-L526

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 5, 2021
@pacoxu pacoxu changed the title update clustere/dns/coredns to 1.8.0 as kubeadm update cluster/dns/coredns to 1.8.0 as kubeadm Mar 5, 2021
@pacoxu
Copy link
Member Author

pacoxu commented Mar 5, 2021

@rajansandeep Updated.

Is there any update for the corefile?

@pacoxu
Copy link
Member Author

pacoxu commented Mar 6, 2021

/assign @bowei @cblecker

Copy link
Member

@MrHohn MrHohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@MrHohn
Copy link
Member

MrHohn commented Mar 8, 2021

/lgtm
for the addon changes.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 8, 2021
@BenTheElder
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, MrHohn, pacoxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 8, 2021
@k8s-ci-robot k8s-ci-robot merged commit 2d3acce into kubernetes:master Mar 8, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 8, 2021
@pacoxu pacoxu deleted the coredns/promote branch June 23, 2021 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants