Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix zero-value custom resource validation with go1.16 #99817

Merged
merged 2 commits into from Mar 5, 2021
Merged

Fix zero-value custom resource validation with go1.16 #99817

merged 2 commits into from Mar 5, 2021

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Mar 5, 2021 •
edited

What type of PR is this?

/kind bug
/kind regression
/priority critical-urgent

Which issue(s) this PR fixes:

Fixes #99804

Does this PR introduce a user-facing change?

NONE

/cc @BenTheElder @uablrek

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Mar 5, 2021
@liggitt
Copy link
Member Author

liggitt commented Mar 5, 2021

/triage accepted
/sig api-machinery

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. triage/accepted Indicates an issue or PR is ready to be actively worked on. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 5, 2021
@liggitt liggitt changed the title WIP - Fix zero-value custom resource validation WIP - Fix zero-value custom resource validation with go1.16 Mar 5, 2021
@k8s-ci-robot k8s-ci-robot added area/apiserver area/cloudprovider area/code-generation area/dependency Issues or PRs related to dependency changes area/kubectl sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. labels Mar 5, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 5, 2021
@liggitt
Copy link
Member Author

liggitt commented Mar 5, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 5, 2021
@liggitt
Copy link
Member Author

liggitt commented Mar 5, 2021

/assign @sttts @apelisse

@liggitt liggitt mentioned this pull request Mar 5, 2021
Closed
@apelisse
Copy link
Member

apelisse commented Mar 5, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 5, 2021
@liggitt
Copy link
Member Author

liggitt commented Mar 5, 2021

flake is #99821

/retest

@BenTheElder
Copy link
Member

/lgtm
/approve

@liggitt
Copy link
Member Author

liggitt commented Mar 5, 2021 •
edited 

=== RUN   TestFirewallNeedsUpdate/When_basic_flow_without_exceptions.
I0305 05:10:42.053527   96318 gce_loadbalancer_external.go:482] ensureTargetPoolAndHealthCheck(a(/fakesvc)): Deleted target pool.
I0305 05:10:42.053623   96318 gce_loadbalancer_external.go:901] Creating firewall k8s-test-cluster-id-node-http-hc for health checks.
I0305 05:10:42.053741   96318 gce_loadbalancer_external.go:905] Created firewall k8s-test-cluster-id-node-http-hc for health checks.
I0305 05:10:42.053839   96318 gce_loadbalancer_external.go:694] Did not find health check k8s-test-cluster-id-node, creating port 10256 path /healthz
I0305 05:10:42.053931   96318 gce_loadbalancer_external.go:703] Created HTTP health check k8s-test-cluster-id-node healthCheckNodePort: 10256
I0305 05:10:42.053968   96318 gce_loadbalancer_external.go:553] Creating targetpool a with 1 healthchecks
    gce_loadbalancer_external_test.go:895: 
        	Error Trace:	gce_loadbalancer_external_test.go:895
        	Error:      	Not equal: 
        	            	expected: false
        	            	actual  : true
        	Test:       	TestFirewallNeedsUpdate/When_basic_flow_without_exceptions.
        	Messages:   	'needsUpdate' didn't return as expected When basic flow without exceptions.
I0305 05:10:42.054063   96318 gce_loadbalancer_external.go:495] ensureTargetPoolAndHealthCheck(a(/fakesvc)): Created health checks k8s-test-cluster-id-node.
I0305 05:10:42.054196   96318 gce_loadbalancer_external.go:498] ensureTargetPoolAndHealthCheck(a(/fakesvc)): Created target pool.
    --- FAIL: TestFirewallNeedsUpdate/When_basic_flow_without_exceptions. (0.00s)

😕

#99837

/retest

@liggitt
Copy link
Member Author

liggitt commented Mar 5, 2021

/retest

@liggitt
Copy link
Member Author

liggitt commented Mar 5, 2021

#99821

/retest

uablrek
uablrek approved these changes Mar 5, 2021
View reviewed changes
Copy link
Contributor

@uablrek uablrek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I applied this PR and built v1.21.0-beta.0.566+7a491401452136-dirty. And now calico starts ok.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, liggitt, uablrek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nikhita
Copy link
Member

nikhita commented Mar 5, 2021

/retest

3 similar comments
@nikhita
Copy link
Member

nikhita commented Mar 5, 2021

/retest

@nikhita
Copy link
Member

nikhita commented Mar 5, 2021

/retest

@nikhita
Copy link
Member

nikhita commented Mar 5, 2021

/retest

@BenTheElder
Copy link
Member

Kubelet config data race
https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/99817/pull-kubernetes-unit/1367800801279348736
/retest

@k8s-ci-robot k8s-ci-robot merged commit feab32b into kubernetes:master Mar 5, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 5, 2021
@liggitt liggitt deleted the zero-value branch March 5, 2021 15:22
@liggitt
Copy link
Member Author

liggitt commented Mar 5, 2021

Kubelet config data race
https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/99817/pull-kubernetes-unit/1367800801279348736

opened #99845

@liggitt liggitt mentioned this pull request Mar 10, 2021
Closed
@deads2k deads2k mentioned this pull request Mar 23, 2021
Merged
@openshift-ci-robot openshift-ci-robot mentioned this pull request Apr 1, 2021
Merged
@apelisse apelisse mentioned this pull request Apr 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uablrek uablrek uablrek approved these changes

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

Assignees

@sttts sttts

@BenTheElder BenTheElder

@apelisse apelisse

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/code-generation area/dependency Issues or PRs related to dependency changes area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

Custom resource empty string / null validation broken with go1.16
7 participants
@liggitt @apelisse @BenTheElder @k8s-ci-robot @nikhita @uablrek @sttts