New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add golang env setup to node e2e #99874
Conversation
/priority backlog |
/lgtm |
/triage accepted |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, ehashman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/99874/pull-kubernetes-unit/1367990215217516544 https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/99874/pull-kubernetes-node-e2e/1367990215259459584/ (cross linking the existing one as well for visibility on occurrences). |
/lgtm nice. You can also invoke I had same issues as you noted, had to set |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Without it, node e2e tests fail to run for me locally:
Technically I'm maybe supposed to use kubetest? idk?
Which issue(s) this PR fixes:
This patch fixes the above issue. Not sure if this is the best way to do this but it works!
Special notes for your reviewer:
n/a
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/cc @BenTheElder
/sig node testing