Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deflake TestPrepareRun #99908

Merged
merged 1 commit into from Mar 8, 2021
Merged

Deflake TestPrepareRun #99908

merged 1 commit into from Mar 8, 2021

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Mar 7, 2021 •
edited

What type of PR is this?

the max-in-flight filter takes a few milliseconds to initialize and raced the /healthz get, producing this flake:

=== RUN   TestPrepareRun
W0306 19:41:03.993313   72776 authorization.go:47] Authorization is disabled
W0306 19:41:03.994050   72776 authentication.go:40] Authentication is disabled
    genericapiserver_test.go:336: [+]ping ok
        [+]log ok
        [-]poststarthook/max-in-flight-filter failed: reason withheld
        healthz check failed
        
    genericapiserver_test.go:337: 
        	Error Trace:	genericapiserver_test.go:337
        	Error:      	Not equal: 
        	            	expected: 200
        	            	actual  : 500
        	Test:       	TestPrepareRun

https://storage.googleapis.com/k8s-gubernator/triage/index.html?pr=1&job=pull-kubernetes-unit&test=PrepareRun

/kind flake

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/flake Categorizes issue or PR as related to a flaky test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 7, 2021
@liggitt liggitt added the area/deflake Issues or PRs related to deflaking kubernetes tests label Mar 7, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 7, 2021
@wojtek-t
Copy link
Member

wojtek-t commented Mar 8, 2021

/lgtm
/approve

Thanks for debugging!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 8, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 348fc2e into kubernetes:master Mar 8, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 8, 2021
@liggitt liggitt deleted the prepare-run-flake branch March 9, 2021 02:35
@spiffxp
Copy link
Member

spiffxp commented Mar 10, 2021

listed as 9th top flake for pull-kubernetes-unit in http://storage.googleapis.com/k8s-metrics/flakes-latest.json

@liggitt
Copy link
Member Author

liggitt commented Mar 10, 2021

Triage board shows no occurrences since this merged, what time period is the top flakes list computed over?

@spiffxp
Copy link
Member

spiffxp commented Mar 10, 2021

1 week

File an issue on us to update the 1 day query to look the same

@spiffxp spiffxp mentioned this pull request Mar 10, 2021
Closed
@spiffxp
Copy link
Member

spiffxp commented Mar 10, 2021

I opened kubernetes/test-infra#21296

@fedebongio
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 11, 2021
This was referenced May 7, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/deflake Issues or PRs related to deflaking kubernetes tests cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@liggitt @wojtek-t @k8s-ci-robot @spiffxp @fedebongio