New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GLBC roles for IngressClass & GCPIngressParams #99965
Conversation
@swetharepakula: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @swetharepakula. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/retest |
Putting this on hold until the plural name is resolved |
do we need to fix the plurals in this PR or can be a follow up? |
Changing the pluralization is a breaking API change. Right now we are confident this hasn't been used because the permissions weren't properly granted. Once we grant permissions, I don't think we'll be able to change the API, since that would break consumers that successfully used it. If I owned this API, I'd want to not be stuck with "paramses" for the rest of the APIs life, but I'll defer to the GCP network folks on that decision. |
👍 sorry then, in my ignorance I thought that was a less important change, |
kubernetes/ingress-gce#1378 will fix the plural name |
2bf9724
to
a8c5110
Compare
Removing hold since kubernetes/ingress-gce#1378 has merged /hold cancel |
thanks. doesn't this need to update cluster/addons/cluster-loadbalancing/glbc/default-svc-controller.yaml to use a release that includes that fix? |
/lgtm resolves a failing network test for 1.21 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: freehan, liggitt, swetharepakula The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
What type of PR is this?
/kind bug
/kind failing-test
What this PR does / why we need it:
This PR adds the roles the GLBC needs, in particular
networking.k8s.io/IngressClasses
andnetworking.gke.io/GCPIngressParams
. Currently there are failing tests because these permissions are missing as seen in the GLBC Logs.TestGrid: https://testgrid.k8s.io/sig-network-ingress-gce-e2e#ingress-gce-e2e as seen in the
Which issue(s) this PR fixes:
Fixes: #93740
Does this PR introduce a user-facing change?
/cc @aojea @prameshj
/assign @freehan
/sig-network