Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GLBC roles for IngressClass & GCPIngressParams #99965

Merged
merged 1 commit into from Mar 11, 2021

Conversation

swetharepakula
Copy link
Member

What type of PR is this?

/kind bug
/kind failing-test

What this PR does / why we need it:

This PR adds the roles the GLBC needs, in particular networking.k8s.io/IngressClasses and networking.gke.io/GCPIngressParams. Currently there are failing tests because these permissions are missing as seen in the GLBC Logs.

TestGrid: https://testgrid.k8s.io/sig-network-ingress-gce-e2e#ingress-gce-e2e as seen in the

Which issue(s) this PR fixes:

Fixes: #93740

Does this PR introduce a user-facing change?

NONE

/cc @aojea @prameshj
/assign @freehan
/sig-network

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. labels Mar 8, 2021
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 8, 2021
@k8s-ci-robot
Copy link
Contributor

@swetharepakula: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

Hi @swetharepakula. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/provider/gcp Issues or PRs related to gcp provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 8, 2021
@freehan
Copy link
Contributor

freehan commented Mar 8, 2021

/ok-to-test
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 8, 2021
@swetharepakula
Copy link
Member Author

/retest

@swetharepakula
Copy link
Member Author

Putting this on hold until the plural name is resolved
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 9, 2021
@liggitt liggitt added this to the v1.21 milestone Mar 9, 2021
@aojea
Copy link
Member

aojea commented Mar 10, 2021

do we need to fix the plurals in this PR or can be a follow up?
it will be nice to finally close #93740

@liggitt
Copy link
Member

liggitt commented Mar 10, 2021

Changing the pluralization is a breaking API change. Right now we are confident this hasn't been used because the permissions weren't properly granted.

Once we grant permissions, I don't think we'll be able to change the API, since that would break consumers that successfully used it.

If I owned this API, I'd want to not be stuck with "paramses" for the rest of the APIs life, but I'll defer to the GCP network folks on that decision.

@aojea
Copy link
Member

aojea commented Mar 10, 2021

👍 sorry then, in my ignorance I thought that was a less important change,

@swetharepakula
Copy link
Member Author

kubernetes/ingress-gce#1378 will fix the plural name

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 11, 2021
@swetharepakula
Copy link
Member Author

Removing hold since kubernetes/ingress-gce#1378 has merged

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 11, 2021
@liggitt
Copy link
Member

liggitt commented Mar 11, 2021

Removing hold since kubernetes/ingress-gce#1378 has merged

thanks. doesn't this need to update cluster/addons/cluster-loadbalancing/glbc/default-svc-controller.yaml to use a release that includes that fix?

@liggitt
Copy link
Member

liggitt commented Mar 11, 2021

/lgtm
/approve

resolves a failing network test for 1.21

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 11, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: freehan, liggitt, swetharepakula

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 11, 2021
@aojea
Copy link
Member

aojea commented Mar 11, 2021

/retest
sig-storage failures

@k8s-ci-robot k8s-ci-robot merged commit 23d4b3b into kubernetes:master Mar 11, 2021
@swetharepakula swetharepakula deleted the glbc-rbac branch March 12, 2021 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Flaky Test][sig-network] Loadbalancing: L7 GCE [Slow] [Feature:Ingress] should conform to Ingress spec
5 participants