Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Circular dependency between kubelet <- docker <- cbr0 <- kubelet on systemd #10379

Closed
justinsb opened this issue Jun 26, 2015 · 3 comments
Closed

Circular dependency between kubelet <- docker <- cbr0 <- kubelet on systemd #10379

justinsb opened this issue Jun 26, 2015 · 3 comments
Labels
priority/backlog Higher priority than priority/awaiting-more-evidence. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/node Categorizes an issue or PR as relevant to SIG Node.
Milestone
v1.0

Comments

@justinsb
Copy link
Member

On systemd, Docker depends on cbr0:
https://github.com/GoogleCloudPlatform/kubernetes/blob/master/cluster/saltbase/salt/docker/docker-defaults#L5

cbr0 is now created by kubelet (after #10312)

But kubelet depends on Docker: https://github.com/GoogleCloudPlatform/kubernetes/blob/master/cluster/saltbase/salt/kubelet/kubelet.service#L5

I'm a bit confused about how to break this loop (if it is even a loop). What I'm seeing is that Docker can't start, but then kubelet fails to start because of the docker dependency.
@mbforbes
Copy link
Contributor

+cc @dchen1107 @cjcullen @zmerlynn

@mbforbes mbforbes added priority/backlog Higher priority than priority/awaiting-more-evidence. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Jun 26, 2015
@mbforbes
Copy link
Contributor

I have an idea how this works (I think some number of things are brought up in a "bad" state, then something is reconfigured, then something gets killed/restarted, then we're good to go), but others I mentioned will be able to clarify the exact timeline and objects involved in these events.

@justinsb
Copy link
Member Author

I was able to break the dependency by changing the kubelet service to not depend on Docker, and changing it to restart indefinitely. Not sure if this is right, but I'll put up a PR when/if I get past the other problems I'm hitting.

justinsb added a commit to justinsb/kubernetes that referenced this issue Jun 26, 2015
@justinsb
Don't make kubelet systemd service depend on Docker
54d3ac9 
Fixes kubernetes#10379
@justinsb justinsb mentioned this issue Jun 26, 2015
Merged
@roberthbailey roberthbailey added this to the v1.0-candidate milestone Jun 26, 2015
@dchen1107 dchen1107 added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Jun 26, 2015
@dchen1107 dchen1107 modified the milestones: v1.0, v1.0-candidate Jun 26, 2015
@dchen1107 dchen1107 mentioned this issue Jun 30, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority/backlog Higher priority than priority/awaiting-more-evidence. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
None yet
Milestone
v1.0
Development

No branches or pull requests
4 participants
@justinsb @mbforbes @dchen1107 @roberthbailey