Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS VPC lookup should not use tag filtering #14466

Closed
chris-codaio opened this issue Sep 24, 2015 · 2 comments · Fixed by #14503
Closed

AWS VPC lookup should not use tag filtering #14466

chris-codaio opened this issue Sep 24, 2015 · 2 comments · Fixed by #14503
Labels
priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@chris-codaio
Copy link
Contributor

In the AWS cloud provider's VPC lookup - given the vpc_id is being read directly from metadata from the local instance, there's no need to additionally filter on the KubernetesCluster tag. Not only is this superfluous, but it prevents sharing a single regional VPC with multiple per-AZ Kubernetes clusters (per best practices).
@mikedanese
Copy link
Member

@justinsb @brendandburns

chris-codaio added a commit to chris-codaio/kubernetes that referenced this issue Sep 24, 2015
@chris-codaio
Fix for issue kubernetes#14466. Don't use tag filtering when looking …
511e3e1 
…up which VPC an AWS node is attached to.
@chris-codaio
Copy link
Contributor Author

#14503

@bgrant0607 bgrant0607 added priority/backlog Higher priority than priority/awaiting-more-evidence. team/community labels Sep 24, 2015
@chris-codaio chris-codaio mentioned this issue Sep 24, 2015
Merged
bgrant0607 added a commit that referenced this issue Sep 25, 2015
@bgrant0607
Merge pull request #14503 from chrisleck/cle-fix-aws-vpc-lookup
1daa365 
Fix for issue #14466.
@justinsb justinsb mentioned this issue Sep 27, 2015
Merged
ananth-at-camphor-networks pushed a commit to Juniper/kubernetes that referenced this issue Oct 3, 2015
@chris-codaio @ananth-at-camphor-networks
Fix for issue kubernetes#14466. Don't use tag filtering when looking …
da13090 
…up which VPC an AWS node is attached to.
mkulke pushed a commit to mkulke/kubernetes that referenced this issue Oct 7, 2015
@chris-codaio
Fix for issue kubernetes#14466. Don't use tag filtering when looking …
868540e 
…up which VPC an AWS node is attached to.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix for issue #14466. chris-codaio/kubernetes
3 participants
@mikedanese @bgrant0607 @chris-codaio