Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

soak cluster should not run daemon/node restart tests #15649

Closed
yujuhong opened this issue Oct 14, 2015 · 5 comments · Fixed by #15722
Closed

soak cluster should not run daemon/node restart tests #15649

yujuhong opened this issue Oct 14, 2015 · 5 comments · Fixed by #15722
Labels
area/test area/test-infra priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@yujuhong
Copy link
Contributor

We should be testing the reliability of a long-running cluster. These tests kill/restart components or nodes in the cluster, defeating the purpose of a soak cluster.
@yujuhong
Copy link
Contributor Author

Example tests:

  • Nodes\sResize
  • Services.*restarting
  • DaemonRestart
  • Nodes\sResize
  • Reboot
  • Etcd failure

@quinton-hoole @ixdy

@ghost
Copy link

ghost commented Oct 14, 2015

@yujuhong Agreed.

Some of them already seem to be skipped:

https://github.com/kubernetes/kubernetes/blob/master/hack/jenkins/e2e.sh#L184

GCE_SOAK_CONTINUOUS_SKIP_TESTS=(
"Density._30\spods"
"Elasticsearch"
"Etcd._SIGKILL"
"external\sload\sbalancer"
"identically\snamed\sservices"
"network\spartition"
"Services.*Type\sgoes\sfrom"
)
Q

@ghost ghost added area/test-infra priority/backlog Higher priority than priority/awaiting-more-evidence. labels Oct 14, 2015
@ghost
Copy link

ghost commented Oct 14, 2015

@ArtfulCoder FYI

@yujuhong
Copy link
Contributor Author

It'd be hard to prevent regression as more tests are added. It might be better if we explicitly define a set of DISRUPTIVE_TESTS, and include them wherever needed, e.g., GCE_PARALLEL_SKIP_TESTS and GCE_SOAK_CONTINUOUS_SKIP_TESTS. That way, people who are adding tests will be aware of the category. @quinton-hoole, WDYT?

@ArtfulCoder ArtfulCoder mentioned this issue Oct 15, 2015
Closed
@ghost
Copy link

ghost commented Oct 15, 2015

@yujuhong Agreed, that seems like a good idea. Want to send in a PR? Or at least open an issue?

yujuhong added a commit to yujuhong/kubernetes that referenced this issue Oct 15, 2015
@yujuhong
e2e: disable component killing/restarting tests in the soak cluster
2dacbc3 
This fixes kubernetes#15649
@yujuhong yujuhong mentioned this issue Oct 15, 2015
Merged
RichieEscarez pushed a commit to RichieEscarez/kubernetes that referenced this issue Dec 4, 2015
@yujuhong @RichieEscarez
e2e: disable component killing/restarting tests in the soak cluster
8873d06 
This fixes kubernetes#15649
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/test area/test-infra priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

e2e: disable component killing/restarting tests in the soak cluster yujuhong/kubernetes
1 participant
@yujuhong