Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New docker images push breaks build/push-official-release.sh script #19623

Closed
david-mcmahon opened this issue Jan 13, 2016 · 6 comments
Closed

New docker images push breaks build/push-official-release.sh script #19623

david-mcmahon opened this issue Jan 13, 2016 · 6 comments
Assignees
@fgrzadkowski
Labels
area/build-release area/release-eng Issues or PRs related to the Release Engineering subproject priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Milestone
v1.2

Comments

@david-mcmahon
Copy link
Contributor

The PR #19061 added functionality to push docker images during the release, but the new workflow requires a special valentine-locked gcloud authorization to proceed. The new workflow simply assumes the user is logged into gcloud with the k8s.production.user@gmail.com user.

We need to figure out a way to seamlessly auth and allow this new functionality to run without interrupting the release workflow.

Rolling back is an option, but preferably we could just fix this somehow.
@david-mcmahon david-mcmahon added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. area/build-release labels Jan 13, 2016
@david-mcmahon david-mcmahon added this to the v1.2 milestone Jan 13, 2016
@david-mcmahon
Copy link
Contributor Author

This might be as simple as adjusting the ACLs for this new upload target.

@luxas
Copy link
Member

luxas commented Jan 14, 2016

It has already been rolled back once. Please find another solution than revert.
I guess you know, but @fgrzadkowski is away for now: #19227 (comment)

Maybe you could assign push permissions to the k8s.production.user?

@fgrzadkowski
Copy link
Contributor

Maybe we can just flag gate this until we have a proper fix?

@luxas
Copy link
Member

luxas commented Jan 14, 2016

@fgrzadkowski It's hard for me to know now if you're away or not :)

@fgrzadkowski
Copy link
Contributor

@luxas I am, but I try to read the most important emails :)

@luxas
Copy link
Member

luxas commented Jan 14, 2016

OK, sounds good :)

@borg286 borg286 mentioned this issue Jan 18, 2016
Closed
@fgrzadkowski fgrzadkowski mentioned this issue Feb 5, 2016
Merged
@fejta fejta added area/release-eng Issues or PRs related to the Release Engineering subproject and removed area/test-infra labels Feb 17, 2016
fgrzadkowski added a commit to fgrzadkowski/kubernetes that referenced this issue Feb 18, 2016
@fgrzadkowski
Switch to k8s.production.user@gmail.com for pushing docker images dur…
2c51e03 
…ing the release.

Fixes kubernetes#19623
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fgrzadkowski fgrzadkowski

Labels
area/build-release area/release-eng Issues or PRs related to the Release Engineering subproject priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Projects
None yet
Milestone
v1.2
Development

No branches or pull requests
5 participants
@fejta @mikedanese @luxas @fgrzadkowski @david-mcmahon