Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EnsureLoadBalancer should take args like namespace and service name #20668

Closed
thockin opened this issue Feb 4, 2016 · 4 comments
Closed

EnsureLoadBalancer should take args like namespace and service name #20668

thockin opened this issue Feb 4, 2016 · 4 comments
Labels
sig/network Categorizes an issue or PR as relevant to SIG Network.

Comments

@thockin
Copy link
Member

thockin commented Feb 4, 2016

We could at least log them, or use them in description fields in cloud provider APIs.

@a-robinson

not a hard fix
@thockin thockin added the sig/network Categorizes an issue or PR as relevant to SIG Network. label Feb 4, 2016
@therc
Copy link
Member

therc commented Feb 5, 2016

Boy, would this have been useful while debugging today. I can take it and add an AWS implementation. Is namespace:service an acceptable format for a short description? There are times I wish kubectl understood that.

@a-robinson
Copy link
Contributor

I think the preferred format is namespace/service, as in our NamespacedName type. Adding it would be much appreciated :)

@therc
Copy link
Member

therc commented Feb 5, 2016

Ugh, that's unfortunate. There's already the TYPE/NAME syntax, e.g. rc/foo and deployment/bar...

@thockin
Copy link
Member Author

thockin commented Feb 5, 2016

yeah, there's not a formal grammar for the structure - it's contextual.

On Thu, Feb 4, 2016 at 6:20 PM, Rudi C notifications@github.com wrote:

Ugh, that's unfortunate. There's already the TYPE/NAME syntax, e.g. rc/foo
and deployment/bar...

—
Reply to this email directly or view it on GitHub
#20668 (comment)
.

@therc therc mentioned this issue Feb 5, 2016
Closed
@therc therc mentioned this issue Feb 5, 2016
Merged
therc pushed a commit to Clarifai/kubernetes that referenced this issue Feb 9, 2016
Pass namespaced service name to cloudprovider's EnsureLoadBalancer
5874b0c 
Also has an AWS implementation that plugs the service name into the ELB and SG.
Log the service name under GCE and OpenStack.
Fixes kubernetes#20668
dims pushed a commit to dims/kubernetes that referenced this issue Feb 8, 2018
Pass namespaced service name to cloudprovider's EnsureLoadBalancer
7164035 
Also has an AWS implementation that plugs the service name into the ELB and SG.
Log the service name under GCE and OpenStack.
Fixes kubernetes#20668
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
sig/network Categorizes an issue or PR as relevant to SIG Network.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@thockin @a-robinson @saad-ali @therc