Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS: We don't appear to _remove_ security group ingress rules on LB modification #21895

Closed
justinsb opened this issue Feb 24, 2016 · 3 comments
Closed

AWS: We don't appear to _remove_ security group ingress rules on LB modification #21895

justinsb opened this issue Feb 24, 2016 · 3 comments
Labels
priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone
v1.2

Comments

@justinsb
Copy link
Member

Just by code inspection here, but we don't seem to remove security group ingress rules on the LoadBalancer, only add them.
@justinsb justinsb added this to the v1.2 milestone Feb 24, 2016
@justinsb justinsb added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Feb 24, 2016
@justinsb justinsb mentioned this issue Feb 25, 2016
Merged
@justinsb
Copy link
Member Author

Fix available, PR pending. Seeking clarification on why some changes were made that I will be breaking with this fix.

@justinsb justinsb mentioned this issue Feb 25, 2016
Merged
@justinsb
Copy link
Member Author

justinsb commented Mar 2, 2016

Fix is in #21987 (waiting on #21907)

justinsb added a commit to justinsb/kubernetes that referenced this issue Mar 3, 2016
@justinsb
AWS: Remove extra load balancer security group ingress rules
62e34da 
The ingress CIDRs are going to be dynamic, and in general we don't want
to leave old ingress rules around.

Fix kubernetes#21895
@justinsb
Copy link
Member Author

justinsb commented Mar 4, 2016

#21987 is LGTMed, just waiting to be merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
v1.2
Development

No branches or pull requests
2 participants
@justinsb @saad-ali