Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS: We should be able to select private subnets #22527

Closed
justinsb opened this issue Mar 4, 2016 · 1 comment · Fixed by #22064
Closed

AWS: We should be able to select private subnets #22527

justinsb opened this issue Mar 4, 2016 · 1 comment · Fixed by #22064
Assignees
@justinsb
Labels
priority/backlog Higher priority than priority/awaiting-more-evidence.
Milestone
v1.2

Comments

@justinsb
Copy link
Member

justinsb commented Mar 4, 2016

For private ELBs, we should still select private subnets.

This was broken by the subnet selection logic recently, so we should fix this regression.
@justinsb justinsb added area/platform/aws priority/backlog Higher priority than priority/awaiting-more-evidence. labels Mar 4, 2016
@justinsb justinsb added this to the v1.2 milestone Mar 4, 2016
@justinsb justinsb self-assigned this Mar 4, 2016
@justinsb justinsb mentioned this issue Mar 4, 2016
Merged
@justinsb
Copy link
Member Author

justinsb commented Mar 4, 2016

Will be fixed by #22064

justinsb added a commit to justinsb/kubernetes that referenced this issue Mar 6, 2016
@justinsb
AWS: Fix problems identifying subnets for internal ELBs
5cf8374 
We tacitly supported this before, but we broke this with the
public-subnet detection.

Fix kubernetes#22527
openshift-publish-robot pushed a commit to openshift/kubernetes that referenced this issue Apr 11, 2019
@k8s-publishing-bot
Merge pull request kubernetes#22527 from smarterclayton/disable_test
c45da30 
UPSTREAM: <drop>: TestNewManagerImplStartProbeMode is flaky 

Origin-commit: 0fc2062c2c5a7f7c7bad21120c026864098efe75
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@justinsb justinsb

Labels
priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Milestone
v1.2
Development

Successfully merging a pull request may close this issue.

AWS: Fix problems identifying subnets for internal ELBs justinsb/kubernetes
1 participant
@justinsb