Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify volume.GetPath() never returns "" #23163

Closed
thockin opened this issue Mar 17, 2016 · 2 comments
Closed

Verify volume.GetPath() never returns "" #23163

thockin opened this issue Mar 17, 2016 · 2 comments
Assignees
@jingxu97
Labels
area/kubelet priority/backlog Higher priority than priority/awaiting-more-evidence. sig/storage Categorizes an issue or PR as relevant to SIG Storage.
Milestone
next-candidate

Comments

@thockin
Copy link
Member

thockin commented Mar 17, 2016

Any call to GetPath should be checked for "" and the pod should fail with a clear indication of why. It's a bug in a driver, but it is surfacing badly, right now.
@thockin thockin added area/kubelet sig/storage Categorizes an issue or PR as relevant to SIG Storage. team/cluster labels Mar 17, 2016
@thockin thockin added this to the v1.3 milestone Mar 17, 2016
@thockin
Copy link
Member Author

thockin commented May 12, 2016

@jingxu97

@thockin thockin added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Jun 3, 2016
@thockin thockin removed this from the v1.3 milestone Jun 8, 2016
@thockin
Copy link
Member Author

thockin commented Jun 8, 2016

I think this is important for paranoia as we add more plugins, but it's a little bit invasive, so we can't do it for 1.3. We can either change .GetPath() to return (string, error) or wrap it in a volumeutil.GetPath(plugin) which returns (string, error) and assert that the returned string is not "", and convert that to error. It means all call-sites (kubelet) need to check that error and change their behavior.

@matchstick FYI

@childsb childsb added this to the next-candidate milestone Jul 14, 2016
@dims dims mentioned this issue Jul 26, 2016
Merged
dims added a commit to dims/kubernetes that referenced this issue Aug 5, 2016
@dims
Verify volume.GetPath() never returns ""
e0edfeb 
Add a new helper method volume.GetPath(Mounter) instead of calling
the GetPath() of the Mounter directly. Check if GetPath() is returning
a "" and convert that into an error. At this point, we only have
information about the type of the Mounter, so let's log that if
there is a problem

Fixes kubernetes#23163
k8s-github-robot pushed a commit that referenced this issue Aug 6, 2016
Merge pull request #29619 from dims/fix-issue-23163
94905bd 
Automatic merge from submit-queue

Verify volume.GetPath() never returns ""

Add a new helper method volume.GetPath(Mounter) instead of calling
the GetPath() of the Mounter directly. Check if GetPath() is returning
a "" and convert that into an error.

Fixes #23163
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jingxu97 jingxu97

Labels
area/kubelet priority/backlog Higher priority than priority/awaiting-more-evidence. sig/storage Categorizes an issue or PR as relevant to SIG Storage.
Projects
None yet
Milestone
next-candidate
Development

No branches or pull requests
3 participants
@childsb @thockin @jingxu97