Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

httpHeaders in httpGet probe does not work for Host header. #24288

Closed
errm opened this issue Apr 14, 2016 · 3 comments
Closed

httpHeaders in httpGet probe does not work for Host header. #24288

errm opened this issue Apr 14, 2016 · 3 comments
Labels
priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/node Categorizes an issue or PR as relevant to SIG Node.

Comments

@errm
Copy link
Contributor

errm commented Apr 14, 2016

I noticed that httpHeaders were added to the httpGet probe in #20116 to fix #14713

Sadly the httpHeaders addition to the httpGet probe does function correctly for all headers except the Host header. I think this must be to do with the way net/http make a special case of the Host header for example and.

I have some code I used to debug the issue that I can share if needed.

@lavalamp lavalamp added sig/node Categorizes an issue or PR as relevant to SIG Node. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Apr 15, 2016
@lavalamp
Copy link
Member

Sigh, letting you set Host was the entire point of providing that option.

errm added a commit to errm/kubernetes that referenced this issue Apr 15, 2016
errm added a commit to errm/kubernetes that referenced this issue Apr 20, 2016
chrislovecnm pushed a commit to chrislovecnm/kubernetes that referenced this issue Apr 28, 2016
alena1108 pushed a commit to rancher/kubernetes that referenced this issue May 20, 2016
shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this issue Dec 1, 2016
shouhong pushed a commit to shouhong/kubernetes that referenced this issue Feb 14, 2017
@bassrock
Copy link

@errm Does the host header work in probes now? I have been browsing the issues but can not tell, as I am having trouble with it in my setup.

@errm
Copy link
Contributor Author

errm commented Mar 7, 2018

@bassrock my fix should be in kubernetes 1.2.3+

I found some code that exercises the issue... could you try this on your cluster https://github.com/errm/muffins

I cannot reproduce in the environment I have to hand that is running k8s 1.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
None yet
Development

No branches or pull requests

3 participants