-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
broken example in NetworkPolicy proposal #28795
Comments
CC @caseydavenport I think we agreed that an empty list means nothing, right? The pseudo-code in the same proposal, along with the comments on the data types, look clear on this subject. |
Yes, I think you're right. That example looks wrong. I think it's from an older version of the proposal that didn't get updated when the semantics were nailed down. |
I believe it should be:
|
MikeSpreitzer
added a commit
to ibm-contribs/kubernetes
that referenced
this issue
Jul 13, 2016
k8s-github-robot
pushed a commit
that referenced
this issue
Aug 2, 2016
Automatic merge from submit-queue Fix the allow-all example NetworkPolicy [![Analytics](https://kubernetes-site.appspot.com/UA-36037335-10/GitHub/.github/PULL_REQUEST_TEMPLATE.md?pixel)]() This is a bug fix, no release note required. Fixes #28795
xingzhou
pushed a commit
to xingzhou/kubernetes
that referenced
this issue
Dec 15, 2016
xingzhou
pushed a commit
to xingzhou/kubernetes
that referenced
this issue
Dec 15, 2016
Automatic merge from submit-queue Fix the allow-all example NetworkPolicy [![Analytics](https://kubernetes-site.appspot.com/UA-36037335-10/GitHub/.github/PULL_REQUEST_TEMPLATE.md?pixel)]() This is a bug fix, no release note required. Fixes kubernetes#28795
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Example 3 in https://github.com/kubernetes/kubernetes/blob/master/docs/proposals/network-policy.md#examples is broken: it has an empty list of ingress rules, and consequently means nothing.
The text was updated successfully, but these errors were encountered: