Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit error events generation in HPA controller #29799

Closed
piosz opened this issue Jul 29, 2016 · 2 comments
Closed

Revisit error events generation in HPA controller #29799

piosz opened this issue Jul 29, 2016 · 2 comments
Assignees
@jszczepkowski
Labels
priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling.
Milestone
next-candidate

Comments

@piosz
Copy link
Member

piosz commented Jul 29, 2016

Currently the HPA behavior is:

  1. Observe high cpu utilization
  2. Scale resource up
  3. Query for metrics of old and newly created pods
  4. Metrics are not available yet, so export error event

This is confusing for users because the HPA is working correctly but the error is exported. Probably we should introduce some grace period before exporting error event.
@piosz piosz added priority/backlog Higher priority than priority/awaiting-more-evidence. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. team/control-plane labels Jul 29, 2016
@piosz
Copy link
Member Author

piosz commented Jul 29, 2016

@kubernetes/autoscaling

@jszczepkowski
Copy link
Contributor

@jszczepkowski

@jszczepkowski jszczepkowski mentioned this issue Aug 4, 2016
Closed
@fgrzadkowski fgrzadkowski added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed priority/backlog Higher priority than priority/awaiting-more-evidence. labels Aug 31, 2016
@fgrzadkowski fgrzadkowski added this to the next-candidate milestone Aug 31, 2016
jszczepkowski added a commit to jszczepkowski/kubernetes that referenced this issue Nov 4, 2016
@jszczepkowski
Improved event generation for HPA.
6adc18e 
Improved event generation for HPA: added grace-period before warning event is generated. Resolves kubernetes#29799.
@jszczepkowski jszczepkowski mentioned this issue Nov 4, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jszczepkowski jszczepkowski

Labels
priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling.
Projects
None yet
Milestone
next-candidate
Development

No branches or pull requests
3 participants
@piosz @fgrzadkowski @jszczepkowski