Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vagrant - Saltstack - Master don't come up #31056

Closed
johscheuer opened this issue Aug 20, 2016 · 0 comments
Closed

Vagrant - Saltstack - Master don't come up #31056

johscheuer opened this issue Aug 20, 2016 · 0 comments
Labels
area/apiserver

Comments

@johscheuer
Copy link
Contributor

johscheuer commented Aug 20, 2016 •
edited

Starting the vargant setup with ./cluster/kube-up.sh results in the following error:

==> master:      Changes:
==> master: ----------
==> master:           ID: /etc/kubernetes/manifests/kube-controller-manager.manifest
==> master:     Function: file.managed
==> master:       Result: False
==> master:      Comment: Unable to manage file: Jinja syntax error: expected token 'end of statement block', got 'feature_gates'; line 82
==> master:
==> master:               ---
==> master:               [...]
==> master:               {% if grains.feature_gates is defined -%}
==> master:                {% set feature_gates = "--feature-gates=" + grains.feature_gates -%}
==> master:               {% endif -%}
==> master:
==> master:               {% set params = "--master=127.0.0.1:8080" + " " + cluster_name + " " + cluster_cidr + " " + allocate_node_cidrs + " " + service_cluster_ip_range + " " + terminated_pod_gc + " " + enable_garbage_collector + " " + cloud_provider  + " " + cloud_config + " " + service_account_key + " " + log_level + " " + root_ca_file -%}
==> master:               {% set params = params + " " feature_gates %}    <======================
==> master:
==> master:
==> master:               # test_args has to be kept at the end, so they'll overwrite any prior configuration
==> master:               {% if pillar['controller_manager_test_args'] is defined -%}
==> master:               {% set params = params + " " + pillar['controller_manager_test_args'] -%}
==> master:               [...]
==> master:               ---
==> master:      Started: 08:36:58.554842
==> master:     Duration: 28.738 ms
==> master:      Changes:
==> master: ----------
...
==> master: Summary
==> master: -------------
==> master: Succeeded: 51 (changed=43)
==> master: Failed:     1
==> master: -------------
==> master: Total states run:     52

-> https://github.com/kubernetes/kubernetes/blob/master/cluster/saltbase/salt/kube-controller-manager/kube-controller-manager.manifest#L82 is missing + after " "

And the Cluster is stuck at the validation step (doesn't come up).
@johscheuer johscheuer mentioned this issue Aug 20, 2016
Merged
johscheuer pushed a commit to johscheuer/kubernetes that referenced this issue Aug 20, 2016
Merge pull request kubernetes#31057 from johscheuer/fix-kube-controll…
7228ac1 
…er-manager.manifest

Automatic merge from submit-queue

Fixes kubernetes#31056

This PR fixes the issue described in kubernetes#31056 - In https://github.com/kubernetes/kubernetes/blob/master/cluster/saltbase/salt/kube-controller-manager/kube-controller-manager.manifest#L82 there is a missing `+` after `" "`

result:
```
==> master: Summary
==> master: -------------
==> master: Succeeded: 52 (changed=43)
==> master: Failed:     0
==> master: -------------
==> master: Total states run:     52
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/apiserver
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@johscheuer @k8s-github-robot