Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tag all storage E2E tests with [Storage] tag so that they can be run explicitly #35542

Closed
saad-ali opened this issue Oct 25, 2016 · 6 comments · Fixed by #39171
Closed

Tag all storage E2E tests with [Storage] tag so that they can be run explicitly #35542

saad-ali opened this issue Oct 25, 2016 · 6 comments · Fixed by #39171
Assignees
@msau42
Labels
priority/backlog Higher priority than priority/awaiting-more-evidence. sig/storage Categorizes an issue or PR as relevant to SIG Storage.

Comments

@saad-ali
Copy link
Member

We have storage E2E tests sprinkled across multiple test suites. When trying to run all storage tests, it is difficult to know which ones to run. To fix this, we should tag all storage/volume plugin e2e tests with the [Storage] tag.

@kubernetes/sig-storage
@saad-ali saad-ali added priority/backlog Higher priority than priority/awaiting-more-evidence. sig/storage Categorizes an issue or PR as relevant to SIG Storage. team/cluster labels Oct 25, 2016
@rootfs
Copy link
Contributor

rootfs commented Oct 25, 2016

would volume work? storage is something used for api storage (etcd)

@saad-ali
Copy link
Member Author

would volume work? storage is something used for api storage (etcd)

Yep, volume works!

@saad-ali
Copy link
Member Author

Assigning to @msau42, who has graciously offered to work on this

@jeffvance
Copy link
Contributor

@saad-ali where is the line for "[Storage]". If I test that an nfs mount is cleaned up when a pod bound to that mount is killed, is that a storage test? What about testing that a PVC binds to the expected PV, is that storage? Thanks.

@saad-ali
Copy link
Member Author

@saad-ali where is the line for "[Storage]". If I test that an nfs mount is cleaned up when a pod bound to that mount is killed, is that a storage test? What about testing that a PVC binds to the expected PV, is that storage? Thanks.

Good question. My feeling is that anything that the storage-sig is responsible should fall in to the label (including all volume plugins, attach/detach controller, kubelet, persistent volume controller). So yes, all your examples should fall in to this label. The idea here is that when we make big breaking changes to some part of the storage infrastructure, we should be able to run all storage E2Es against the change with one command. Optionally we could have a storage test suite that runs all theses tests as part of CI.

@jeffvance
Copy link
Contributor

@saad-ali I agree and have updated in flight pr #38214

@msau42 msau42 mentioned this issue Dec 22, 2016
Merged
copejon added a commit to copejon/kubernetes that referenced this issue Jan 9, 2017
@copejon
Tag persistent volume GCE tests [Serial]
fd15732 
Added [Volume] tag per issue kubernetes#35542; added [Flaky] to GCE tests until confirmed fixed.  Added [Serial] to NFS to address possible cross test contamination.
copejon added a commit to copejon/kubernetes that referenced this issue Jan 9, 2017
@copejon
Tag persistent volume GCE tests [Serial]
f85ef3b 
Added [Volume] tag per issue kubernetes#35542; added [Flaky] to GCE tests until confirmed fixed.  Added [Serial] to NFS to address possible cross test contamination.
k8s-github-robot pushed a commit that referenced this issue Jan 12, 2017
Merge pull request #39171 from msau42/tag-e2e-storage
a1f54a8 
Automatic merge from submit-queue

Add [Volume] tag to all the volume-related E2E tests.

**What this PR does / why we need it**:
Tags all the volume/storage related e2e tests to make it easier to run a volume test suite.

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
fixes #35542 

**Special notes for your reviewer**:
Please let me know if there are tests that should/should not be included.

**Release note**:
NONE
```release-note
```
jayunit100 pushed a commit to jayunit100/kubernetes that referenced this issue Jan 13, 2017
@copejon @jayunit100
Tag persistent volume GCE tests [Serial]
ddb56f9 
Added [Volume] tag per issue kubernetes#35542; added [Flaky] to GCE tests until confirmed fixed.  Added [Serial] to NFS to address possible cross test contamination.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@msau42 msau42

Labels
priority/backlog Higher priority than priority/awaiting-more-evidence. sig/storage Categorizes an issue or PR as relevant to SIG Storage.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add [Volume] tag to all the volume-related E2E tests. msau42/kubernetes
4 participants
@jeffvance @rootfs @saad-ali @msau42