Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't create cluster with not registered master #36167

Closed
piosz opened this issue Nov 3, 2016 · 4 comments · Fixed by #36214
Closed

Can't create cluster with not registered master #36167

piosz opened this issue Nov 3, 2016 · 4 comments · Fixed by #36214
Assignees
@roberthbailey @jszczepkowski
Labels
area/nodecontroller kind/bug Categorizes issue or PR as related to a bug. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle.
Milestone
v1.5

Comments

@piosz
Copy link
Member

piosz commented Nov 3, 2016

Kubernetes version (use kubectl version): HEAD

Environment: GCE

What happened:
When I set up REGISTER_MASTER_KUBELET=false I can see the following message:

... calling validate-cluster
Waiting for 3 ready nodes. 1 ready nodes, 1 registered. Retrying.
Found 4 nodes, but expected 3. Your cluster may not behave correctly.
Found 4 node(s).
NAME                           STATUS                     AGE
kubernetes-master              Ready,SchedulingDisabled   19s
kubernetes-minion-group-jifk   NotReady                   16s
kubernetes-minion-group-n5ao   NotReady                   15s
kubernetes-minion-group-y419   NotReady                   17s

What you expected to happen:
master should not be registered
@piosz piosz added kind/bug Categorizes issue or PR as related to a bug. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. labels Nov 3, 2016
@piosz
Copy link
Member Author

piosz commented Nov 3, 2016

cc @kubernetes/sig-cluster-lifecycle @mikedanese @roberthbailey

@roberthbailey
Copy link
Contributor

Looks like the env var isn't being respected any longer by the master scripts (but the logic for # of expected nodes did adjust correctly).

@roberthbailey
Copy link
Contributor

/cc @jszczepkowski

I think this may have broken in #33655 because it added

+  if [[ -z "${KUBERNETES_MASTER_NAME:-}" ]]; then
 +    KUBERNETES_MASTER_NAME="${MASTER_NAME}"
 +  fi

which unconditionally sets the field that tells a kubelet to register with the master outside of the guard that checks REGISTER_MASTER_KUBELET.

@piosz piosz added this to the v1.5 milestone Nov 4, 2016
jszczepkowski added a commit to jszczepkowski/kubernetes that referenced this issue Nov 4, 2016
@jszczepkowski
Fixed not registering master during cluster creation.
5e8c569 
Fixed not registering master during cluster creation. This fixes kubernetes#36167.
@jszczepkowski jszczepkowski mentioned this issue Nov 4, 2016
Merged
@jszczepkowski
Copy link
Contributor

Fix in progress: #36214.

There was a problem caused by unconditional setting KUBELET_APISERVER on the master in #33655.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roberthbailey roberthbailey

@jszczepkowski jszczepkowski

Labels
area/nodecontroller kind/bug Categorizes issue or PR as related to a bug. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle.
Projects
None yet
Milestone
v1.5
Development

Successfully merging a pull request may close this issue.

Fixed not registering master during cluster creation. jszczepkowski/kubernetes
4 participants
@roberthbailey @piosz @jszczepkowski @k8s-github-robot