Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent find-path behavior for cni binaries #46476

Closed
abhinavdahiya opened this issue May 26, 2017 · 3 comments
Closed

Inconsistent find-path behavior for cni binaries #46476

abhinavdahiya opened this issue May 26, 2017 · 3 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/node Categorizes an issue or PR as relevant to SIG Node.

Comments

@abhinavdahiya
Copy link

abhinavdahiya commented May 26, 2017 •
edited

Is this a request for help?: Yes

What keywords did you search in Kubernetes issues before filing this one? (If you have found any duplicates, you should instead reply there.): cni binaries, cni vendorDirPrefix

Is this a BUG REPORT or FEATURE REQUEST? : feature

What happened:
Inconsistent find-path priority order for cni binaries in CNI:

cni plugin loopback binary path find priority order
The priority order is vendor dir > bin dir

cninet := &libcni.CNIConfig{
	Path: []string{vendorCNIDir(vendorDirPrefix, "loopback"), binDir},
}

for the all other binaries the path find priority order
The priority order is bin dir > vendor dir

cninet := &libcni.CNIConfig{
	Path: []string{binDir, vendorDir},
}

What you expected to happen:
It would be better if this behavior is consistent. Most probably, vendor dir > bin dir makes more sense.

/cc: @aaronlevy
@apelisse apelisse added the sig/node Categorizes an issue or PR as relevant to SIG Node. label May 26, 2017
abhinavdahiya pushed a commit to abhinavdahiya/kubernetes that referenced this issue May 30, 2017
Fix inconsistenty in finding cni binaries
73555e7 
Fixes [kubernetes#46476]

Signed-off-by: Abhinav Dahiya <abhinav.dahiya@coreos.com>
@abhinavdahiya abhinavdahiya mentioned this issue May 30, 2017
Merged
k8s-github-robot pushed a commit that referenced this issue Jun 3, 2017
Merge pull request #46609 from abhinavdahiya/fix_inconsistent_path_or…
747b3b1 
…der_cni

Automatic merge from submit-queue (batch tested with PRs 46782, 46719, 46339, 46609, 46494)

Fix inconsistency in finding cni binaries

Fixes [#46476]

Signed-off-by: Abhinav Dahiya <abhinav.dahiya@coreos.com>



**What this PR does / why we need it**:
This fixes the inconsistency in finding the appropriate cni binaries. 

Currently `lo` cniNetwork follows vendorCniDir > binDir whereas default for all others is binDir > vendorCniDir. This PR makes vendorCniDir > binDir as default behavior.

**Why we need it**:
Hypercube right now ships cni binaries in /opt/cni/bin. 
And to use latest version of calico you need to override kubelet's /opt/cni/bin from host which means all other cni plugins (flannel, loopback etc...) have to be mounted from host too. Keeping vendordir at higher order allows easy installation of newer versions of plugins.
mrIncompetent pushed a commit to kubermatic/kubernetes that referenced this issue Jun 6, 2017
Fix inconsistenty in finding cni binaries
d6da821 
Fixes [kubernetes#46476]

Signed-off-by: Abhinav Dahiya <abhinav.dahiya@coreos.com>
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 25, 2017
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle rotten
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 24, 2018
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@apelisse @abhinavdahiya @k8s-ci-robot @fejta-bot