Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS provider needs refactoring #47394

Closed
justinsb opened this issue Jun 13, 2017 · 2 comments
Closed

AWS provider needs refactoring #47394

justinsb opened this issue Jun 13, 2017 · 2 comments
Assignees
@justinsb
Milestone
v1.7

Comments

@justinsb
Copy link
Member

A recent commit introduced some issues into the aws cloudprovider which need to be fixed before we cut the 1.7 branch, or else backporting will be needlessly hard.
@k8s-github-robot
Copy link

@justinsb There are no sig labels on this issue. Please add a sig label by:
(1) mentioning a sig: @kubernetes/sig-<team-name>-misc
(2) specifying the label manually: /sig <label>

Note: method (1) will trigger a notification to the team. You can find the team list here and label list here

@k8s-github-robot k8s-github-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jun 13, 2017
@justinsb justinsb added this to the v1.7 milestone Jun 13, 2017
@justinsb justinsb self-assigned this Jun 13, 2017
@k8s-github-robot k8s-github-robot removed the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jun 13, 2017
justinsb added a commit to justinsb/kubernetes that referenced this issue Jun 13, 2017
@justinsb
Follow our go code style: error -> err
f10c9ee 
Issue kubernetes#47394
@justinsb justinsb mentioned this issue Jun 13, 2017
Merged
justinsb added a commit to justinsb/kubernetes that referenced this issue Jun 13, 2017
@justinsb
Use awsInstanceID to query instances
0a17408 
Also reuse existing mapping code, rather than reimplementing.

Issue kubernetes#47394
enisoc pushed a commit to enisoc/kubernetes that referenced this issue Jun 13, 2017
Merge pull request kubernetes#47395 from justinsb/followup_47215_2
4d31eca 
Automatic merge from submit-queue

AWS cleanup

Rationalize the existing code.

```release-note
NONE
```

 Issue kubernetes#47394
@justinsb
Copy link
Member Author

Fixed in #47395

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@justinsb justinsb

Labels
None yet
Projects
None yet
Milestone
v1.7
Development

No branches or pull requests
2 participants
@justinsb @k8s-github-robot