Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include domain name or not in the static pod names #5936

Closed
yujuhong opened this issue Mar 25, 2015 · 3 comments · Fixed by #6024
Closed

Include domain name or not in the static pod names #5936

yujuhong opened this issue Mar 25, 2015 · 3 comments · Fixed by #6024
Labels
area/usability kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. sig/node Categorizes an issue or PR as relevant to SIG Node.

Comments

@yujuhong
Copy link
Contributor

Static pods (pods from file/http sources) are named as podName-hostname. Because hostname can include the domain name or not, the actual pod name varies.
E.g.
fluentd-to-elasticsearch-e2e-test-jenkins-minion-4gnu vs
fluentd-to-elasticsearch-e2e-test-jenkins-minion-4gnu.c.kubernetes-jenkins.internal

Pod names are shorter and easier to read if we do not include the domain name. The downside is that we would not be able to handle nodes on different domains (would that be something we need to support)?

@yujuhong yujuhong added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. area/usability priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Mar 25, 2015
@thockin
Copy link
Member

thockin commented Mar 25, 2015

How do you get the node name from hostname? The hostname spec is unclear
whether it includes domain or not. You could just take the first token, I
suppose.

On Wed, Mar 25, 2015 at 11:25 AM, Yu-Ju Hong notifications@github.com
wrote:

Static pods (pods from file/http sources) are named as podName-hostname.
Because hostname can include the domain name or not, the actual pod name
varies.
E.g.
fluentd-to-elasticsearch-e2e-test-jenkins-minion-4gnu vs

fluentd-to-elasticsearch-e2e-test-jenkins-minion-4gnu.c.kubernetes-jenkins.internal

Pod names are shorter and easier to read if we do not include the domain
name. The downside is that we would not be able to handle nodes on
different domains (would that be something we need to support)?


Reply to this email directly or view it on GitHub
#5936.

@yujuhong
Copy link
Contributor Author

Kubelet uses hostname -f to get the fully qualified domain name, but user can also override the hostname if they want by passing it to the config.

My question was more about whether we should grab the first token, or we should consider the possibility of nodes from different domains :)

@thockin
Copy link
Member

thockin commented Mar 25, 2015

I think it's reasonable to assume (and document) that hostnames must be in
the same domain or else the user must override.

I think that is sane..

On Wed, Mar 25, 2015 at 1:39 PM, Yu-Ju Hong notifications@github.com
wrote:

Kubelet uses hostname -f to get the fully qualified domain name, but user
can also override the hostname if they want by passing it to the config.

My question was more about whether we should grab the first token, or we
should consider the possibility of nodes from different domains :)


Reply to this email directly or view it on GitHub
#5936 (comment)
.

yujuhong added a commit to yujuhong/kubernetes that referenced this issue Mar 26, 2015
This increases the readability of pods by avoiding long names.

This fixes kubernetes#5936
akram pushed a commit to akram/kubernetes that referenced this issue Apr 7, 2015
This increases the readability of pods by avoiding long names.

This fixes kubernetes#5936
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/usability kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants