Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for new Docker 1.6 cgroup parent flag #6991

Closed
guenter opened this issue Apr 17, 2015 · 11 comments
Closed

Add support for new Docker 1.6 cgroup parent flag #6991

guenter opened this issue Apr 17, 2015 · 11 comments
Labels
area/isolation area/platform/mesos priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. sig/node Categorizes an issue or PR as relevant to SIG Node.

Comments

@guenter
Copy link
Contributor

guenter commented Apr 17, 2015

Docker 1.6 allows setting the parent cgroup which allows us to set the parent for pods, see #5671

@guenter
Copy link
Contributor Author

guenter commented Apr 17, 2015

I am planning to work on this.

@ConnorDoyle
Copy link
Contributor

Could someone add the Mesos integration tag?

@roberthbailey
Copy link
Contributor

When you say upgrade the dependency, as you implying that we will only support Docker 1.6+ going forward? I think we have quite a few users that are using older version of Docker on their systems that would still like to run kubernetes.

@ConnorDoyle
Copy link
Contributor

@roberthbailey As mentioned in the description, a major motivation is to use the new --cgroup-parent flag. I agree, there's no reason to break compatibility with older versions of Docker. The docker interface... interface already exposes a Version(), so we should be able to detect whether the intalled docker supports the new flags. @guenter, maybe this issue should be renamed to "Add support for new Docker 1.6 flags".

See: https://github.com/GoogleCloudPlatform/kubernetes/blob/fa4363d493551e0c27729e229fc35ea2790c186f/pkg/kubelet/dockertools/docker.go#L68

@roberthbailey
Copy link
Contributor

Thanks. Just want to make sure we aren't going to stop supporting older versions.

@roberthbailey roberthbailey added priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Apr 17, 2015
@guenter guenter changed the title Upgrade Docker dependency to 1.6 Add support for new Docker 1.6 cgroup parent flag Apr 17, 2015
@bgrant0607
Copy link
Member

Which use of cgroup_parent do you intend? Just to put a box around all pods run by Kubernetes?

cc @vishh @vmarmol

See also #147 and #5980.

@ConnorDoyle
Copy link
Contributor

@bgrant0607 I think so, provided a top-level container (and a kubelet flag to set it) be a worthwhile first pass compatible with future plans. WDYT?

@vishh
Copy link
Contributor

vishh commented Apr 17, 2015

Our immediate goal are:

  1. limit the total resource consumption of all containers that do not have any limits specified (batch),
  2. limit system daemon resources usage.

Pod level resource isolation will land after that.

IIUC, what is required for Mesos is to configure kubelet to run itself and all the pods under a configurable cgroup hierarchy. That sounds fine.

@ConnorDoyle
Copy link
Contributor

@vishh @bgrant0607 cool, I think we're on the same page.

@bgrant0607
Copy link
Member

Pod limits is #168, btw.

@guenter
Copy link
Contributor Author

guenter commented May 1, 2015

Implemented by #7277

@guenter guenter closed this as completed May 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/isolation area/platform/mesos priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
None yet
Development

No branches or pull requests

5 participants