Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E: Modify networking.go to verify containers (rather than client) can access internet. #9662

Closed
jayunit100 opened this issue Jun 11, 2015 · 3 comments
Assignees
Labels
area/test-infra priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone

Comments

@jayunit100
Copy link
Member

From a recent thread https://groups.google.com/forum/#!topic/google-containers/aDdYFLcQxk4 , it looks like we can modify networking.go to do a test of external connectivity which is actually useful :).

The snippet im suggesting we replace ...

resp, err := http.Get("http://google.com")
        if err != nil {
            Failf("Unable to connect/talk to the internet: %v", err)
        }
        if resp.StatusCode != http.StatusOK {
            Failf("Unexpected error code, expected 200, got, %v (%v)", resp.StatusCode, resp)
        }

... in its place, we should write a test w/ a simple pod which pings google FROM INSIDE A CONTAINER and prints "SUCCESS" after its done, then grep for the SUCCESS string.

@timothysc
Copy link
Member

report sure.. but many people want an air-gaped cluster.

@jayunit100
Copy link
Member Author

Yeah ....
This might be a warning report rather than an error.

@ArtfulCoder ArtfulCoder added priority/backlog Higher priority than priority/awaiting-more-evidence. area/test-infra labels Jun 12, 2015
@ArtfulCoder ArtfulCoder assigned ghost Jun 12, 2015
@ghost ghost added this to the v1.0 milestone Jun 23, 2015
@ghost ghost removed their assignment Jun 23, 2015
@piosz piosz self-assigned this Jun 24, 2015
@piosz
Copy link
Member

piosz commented Jun 24, 2015

Increasing priority due to regression #10281

@piosz piosz added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed priority/backlog Higher priority than priority/awaiting-more-evidence. labels Jun 24, 2015
piosz added a commit to piosz/kubernetes that referenced this issue Jun 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test-infra priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

No branches or pull requests

4 participants