Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change non-step usages of out.Step to use another logging method #10607

Closed
spowelljr opened this issue Feb 24, 2021 · 0 comments
Closed

Change non-step usages of out.Step to use another logging method #10607

spowelljr opened this issue Feb 24, 2021 · 0 comments
Assignees
@spowelljr
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone
v.1.19.0

Comments

@spowelljr
Copy link
Member

out.Step has special logic in it that outputs what the current step is, however, out.Step is being used in instances that aren't steps and is causing duplicate instances of the same step to be logged.

Any usage of out.Step that is not in fact a step should be changed to another logging method, possibly out.Infof will work, or maybe a brand new func needs to be created.
@spowelljr spowelljr added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Feb 24, 2021
@spowelljr spowelljr added this to the v.1.19.0-candidate milestone Feb 25, 2021
@spowelljr spowelljr mentioned this issue Feb 25, 2021
Merged
@spowelljr spowelljr self-assigned this Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spowelljr spowelljr

Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
v.1.19.0
Development

No branches or pull requests
1 participant
@spowelljr