Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --audit flag to minikube logs that only shows audit #13978

Closed
spowelljr opened this issue Apr 18, 2022 · 4 comments · Fixed by #13991
Closed

Add --audit flag to minikube logs that only shows audit #13978

spowelljr opened this issue Apr 18, 2022 · 4 comments · Fixed by #13991
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/improvement Categorizes issue or PR as related to improving upon a current feature. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@spowelljr
Copy link
Member

It would be good to add an --audit flag to minikube logs that only shows the audit logs.

Currently, if you run minikube logs the audit logs are all the way at the top (after last start logs and such) which can be time consuming to scroll up to.

Example of that the audit logs look like:

==> Audit <==
|---------|---------------------|----------|--------------|---------|-------------------------------|-------------------------------|
| Command |        Args         | Profile  |     User     | Version |          Start Time           |           End Time            |
|---------|---------------------|----------|--------------|---------|-------------------------------|-------------------------------|
| delete  | --user minikube-gui | minikube | minikube-gui | v1.25.2 | Mon, 18 Apr 2022 15:52:01 PDT | Mon, 18 Apr 2022 15:52:01 PDT |
|---------|---------------------|----------|--------------|---------|-------------------------------|-------------------------------|
@spowelljr spowelljr added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/backlog Higher priority than priority/awaiting-more-evidence. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/improvement Categorizes issue or PR as related to improving upon a current feature. labels Apr 18, 2022
@EdwinWalela
Copy link
Contributor

That would be a helpful addition to the minikube logs command. I would like to take this up.

To confirm:

  • Will the outputAudit function need to be exported? i.e func OutputAudit(lines int) error
    func outputAudit(lines int) error {
  • Are there tests that I might need to add for the new feature?

@spowelljr
Copy link
Member Author

Hi @EdwinWalela, to assign the issue to yourself comment /assign.

The outputAudit func will likely need to be exported.

You can add a test to the --audit log here: https://github.com/kubernetes/minikube/blob/master/test/integration/functional_test.go#L1229

@EdwinWalela
Copy link
Contributor

/assign

@EdwinWalela
Copy link
Contributor

@spowelljr I've opened a PR to address this issue. Let me know if there's something I missed out on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/improvement Categorizes issue or PR as related to improving upon a current feature. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants