-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prototype minikube qemu driver with dedicated network #14692
Comments
There are some similar solutions to this, that might also be used. For mac, there is "vde" and "socket". For linux, there is "tap" and "bridge" (for reference, the default networking is called "user" and uses "slirp" lib) More details on: https://wiki.qemu.org/Documentation/Networking The main difference is that with "user", your IP is not accessible from host (like Docker Desktop) This means that every node will be "10.0.2.15", and we need to use tunneling to reach it from host. But when using "vde" (or the others), you get an IP address reachable from host (like Docker Engine) This is more similar to the traditional minikube setup (before kic), with things like |
In the qemu driver, this is chosen with the "network" parameters:
In the driver code, it's in |
vde_vmnet will be deprecated by https://github.com/lima-vm/socket_vmnet |
I think it will work the same, just replace Network: "vde" with Network: "socket"
However, it might require some more code to do the prefix command wrapper ?
There is no such execution parameter, in the current qemu driver at least.
But it shouldn't be a big change, later on. https://github.com/machine-drivers/docker-machine-driver-qemu (and qemu2) |
Yes, but socket_vmnet is more efficient (321 Mbps vs 686 Mbps)
The command wrapper is not needed if you pass the FD by yourself. |
It would need some code to pass the fd, either way :-) And for the network type |
If I understand this prototype correctly, the user will be required to set up the network:
And then the socket location will be passed to the In the future, one might imagine the driver managing its own private networks. That requires a similar admin privileges setup, as other drivers (e.g. libvirt) It will probably be out of scope for the libmachine driver, but minikube might do it. There was some similar evolution (of networks), in the container drivers (docker/podman) |
Btw QEMU 7.1 will add the native support for vmnet, but that requires running the entire QEMU as the root (So I'm not going to use it for Lima) |
Sounds good! I don't know how slow slirp ("user") is, compared to the other two, but it will probably stay as the default. |
What Happened?
https://github.com/lima-vm/vde_vmnet
Attach the log file
n/a
Operating System
No response
Driver
No response
The text was updated successfully, but these errors were encountered: