Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO_PROXY doesn't respect addr/range - contrary to documentation #3827

Closed
wayne8l opened this issue Mar 7, 2019 · 5 comments
Closed

NO_PROXY doesn't respect addr/range - contrary to documentation #3827

wayne8l opened this issue Mar 7, 2019 · 5 comments
Labels
area/networking networking issues good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/documentation Categorizes issue or PR as related to documentation. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@wayne8l
Copy link

wayne8l commented Mar 7, 2019

For whatever reason, NO_PROXY does not respect an addr/range argument in Ubuntu 16.04. Therefore, 192.168.99.1/24 will not make a no proxy exception for an address in that subnet

In this case, what I found works is to replace it with a specific ip address of the minikube vm in NO_PROXY, which in my case was 192.168.99.100.

Please add this to the documentation, thanks!

@tstromberg
Copy link
Contributor

I assume you mean this document: https://github.com/kubernetes/minikube/blob/master/docs/http_proxy.md#using-minikube-with-an-http-proxy

Just curious - what error did you see with this, and what version of minikube was it on?

I had assumed when I last changed the doc that NO_PROXY parsing allowed for subnets, it seems like Go's HTTP library should allow for it. I guess not!

@tstromberg tstromberg added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/documentation Categorizes issue or PR as related to documentation. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. area/networking networking issues labels Mar 7, 2019
@tstromberg tstromberg changed the title Documentation issue regarding proxy NO_PROXY doesn't respect addr/range - contrary to documentation Mar 7, 2019
@wayne8l
Copy link
Author

wayne8l commented Mar 7, 2019

I was using virtualbox (installed through apt) on Ubuntu 16.04, and issuing http requests through curl and Firefox. My guess is that addr/range in NO_PROXY is not universally implemented.

@wayne8l
Copy link
Author

wayne8l commented Mar 7, 2019

I was on the latest version of minikube, but I think this has nothing to do with minikube.

@wayne8l
Copy link
Author

wayne8l commented Mar 7, 2019

This is not an issue when running minikube, but it is an issue when running kubernetes services through nodeport in minikube when I want to curl in or use a browser.

@tstromberg tstromberg added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Mar 8, 2019
@tstromberg
Copy link
Contributor

Updated https://github.com/kubernetes/minikube/blob/master/docs/http_proxy.md

Thanks for the bug report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/networking networking issues good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/documentation Categorizes issue or PR as related to documentation. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

No branches or pull requests

2 participants