Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make MAC address settable #3848

Closed
geiseri opened this issue Mar 11, 2019 · 4 comments
Closed

Make MAC address settable #3848

geiseri opened this issue Mar 11, 2019 · 4 comments
Labels
area/networking networking issues kind/feature Categorizes issue or PR as related to a new feature. priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. r/2019q2 Issue was last reviewed 2019q2

Comments

@geiseri
Copy link

geiseri commented Mar 11, 2019 •
edited by tstromberg
Loading

I use the kvm2 driver on debian linux but when I create a new minikube instance I do not get the ability to specify the IP or macaddress for the --kvm-network interface.

This is annoying because I need to take the extra step of minikube ssh and check the IP address of eth0.

It would be nice to be able to supply a static address of some sort so I can have a DHCP reservation or a well-known address. One other option would be to offer the IP address of eth0 as an option for minikube ip. Thanks for minikube, its very nice for small deployments who do not want to fight the battle of the entire stack.
@tstromberg
Copy link
Contributor

IP setting is covered in #2938

I'll leave this issue open for setting the MAC address. Help wanted!

@tstromberg tstromberg added kind/feature Categorizes issue or PR as related to a new feature. area/networking networking issues priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. labels Mar 13, 2019
@tstromberg tstromberg changed the title Be able to specify a static address with --kvm-network Make MAC address settable Mar 13, 2019
@tstromberg tstromberg added the r/2019q2 Issue was last reviewed 2019q2 label May 23, 2019
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 21, 2019
@tstromberg tstromberg removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 20, 2019
@tstromberg
Copy link
Contributor

On second thought - I'm not convinced yet about adding the ability to set a MAC address. I just don't see the use case. Do you mind clarifying?

Making the IP settable is entirely reasonable.

@tstromberg
Copy link
Contributor

Closing due to lack of updates. I'm not yet convinced of the necessity here, so I don't think we are likely to solve it.

If someone provides a PR - I'd be OK with merging it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/networking networking issues kind/feature Categorizes issue or PR as related to a new feature. priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. r/2019q2 Issue was last reviewed 2019q2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tstromberg @geiseri @k8s-ci-robot @fejta-bot