Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyper-V: Use the "Default Switch" (NAT based) by default #4079

Closed
tstromberg opened this issue Apr 11, 2019 · 7 comments
Closed

Hyper-V: Use the "Default Switch" (NAT based) by default #4079

tstromberg opened this issue Apr 11, 2019 · 7 comments
Assignees
Labels
co/hyperv HyperV related issues priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. r/2019q2 Issue was last reviewed 2019q2 roadmap/2019 Items on the 2019 roadmap
Milestone

Comments

@tstromberg
Copy link
Contributor

tstromberg commented Apr 11, 2019

Manually configuring HyperV networks is painful and a cause of many user issues. We should just create the network automatically, as with other VM drivers.

@tstromberg tstromberg added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Apr 11, 2019
@tstromberg tstromberg added co/hyperv HyperV related issues r/2019q2 Issue was last reviewed 2019q2 roadmap/2019 Items on the 2019 roadmap labels May 23, 2019
@medyagh
Copy link
Member

medyagh commented Jun 6, 2019

That should be do-able, Microsoft has instructions to create virtual switch in command line
https://docs.microsoft.com/en-us/virtualization/hyper-v-on-windows/quick-start/connect-to-network

the only tricky part I see is, deciding which adaptor to connect the switch to ( WIFI, Ethernet, other virtual interfaces)

@tstromberg tstromberg added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Jul 12, 2019
@tstromberg tstromberg self-assigned this Jul 12, 2019
@tstromberg tstromberg changed the title hyperv should automatically create network switches hyperv: Use the "Default Switch" (NAT based) by default Jul 16, 2019
@tstromberg
Copy link
Contributor Author

tstromberg commented Jul 16, 2019

This would address many bugs, such as #3963

@gbraad has mentioned that this may cause breakage when a VM is moved between network adapters.

@laozc
Copy link
Contributor

laozc commented Jul 17, 2019

PR machine-drivers/machine#18 addressed the issue to use the default switch when not specified.

@tstromberg tstromberg modified the milestones: v1.3.0, v1.4.0 Candidate Aug 6, 2019
@tstromberg tstromberg changed the title hyperv: Use the "Default Switch" (NAT based) by default Hyper-V: Use the "Default Switch" (NAT based) by default Aug 14, 2019
@tstromberg
Copy link
Contributor Author

Once machine-drivers/machine#18 is merged, I believe this can be addressed by repinning the version of the machine-drivers we import.

I believe this can be landed by v1.4.0 (Sep 16)

@tstromberg tstromberg removed their assignment Sep 4, 2019
@tstromberg
Copy link
Contributor Author

Update: machine-drivers/machine#18 is looking good, waiting on review by @gbraad - the end is near!

@tstromberg
Copy link
Contributor Author

This landed with #5311

@gbraad
Copy link
Contributor

gbraad commented Sep 12, 2019

Sorry for the delay.

Since minikube does not enforce any minimum version of Windows, there is a possibility of a localization issue. We decided to merge nonetheless and fix this later if proving to be an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
co/hyperv HyperV related issues priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. r/2019q2 Issue was last reviewed 2019q2 roadmap/2019 Items on the 2019 roadmap
Projects
None yet
Development

No branches or pull requests

5 participants