Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from dep to Go Modules #4234

Closed
myhro opened this issue May 9, 2019 · 2 comments · Fixed by #4241
Closed

Migrate from dep to Go Modules #4234

myhro opened this issue May 9, 2019 · 2 comments · Fixed by #4241
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@myhro
Copy link
Contributor

myhro commented May 9, 2019

Hi,

I've been working on migrating minikube's current dependency management from Go dep to Go modules, mainly because I like to build projects with git clone/make and forgetting about GOPATH. It ended up simplifying the build infrastructure a bit, so I thought about upstreaming the changes.

The only reference to Go modules I found is this comment from last September on issue #3037, related to the last godep to dep migration.

Hence the question: are you interested in this change? If so, I'll prepare a proper pull request (e.g. updating the related documentation).

Regards,
Tiago.
@tstromberg tstromberg changed the title Move to Go modules? Migrate from dep to Go Modules May 9, 2019
@tstromberg
Copy link
Contributor

Yes! I would very much like to see minikube migrate to Go Modules, but haven't had a chance to prioritize it. I think the timing is right now, as other Kubernetes components have begun making the jump.

Please feel free to assign me as a reviewer for any PR's that make this happen.

@tstromberg tstromberg changed the title Migrate from dep to Go Modules Migrate from dep to Go Modules May 9, 2019
@tstromberg tstromberg added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels May 9, 2019
@myhro myhro mentioned this issue May 10, 2019
Merged
@myhro
Copy link
Contributor Author

myhro commented May 10, 2019

@tstromberg That's great. Thanks!

I'm having trouble to pass the CLA check on the related PR, so I'll assign it to you as soon as this is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Go modules support myhro/minikube
2 participants
@tstromberg @myhro