Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove show-libmachine-logs flag #814

Closed
r2d4 opened this issue Nov 9, 2016 · 0 comments
Closed

Remove show-libmachine-logs flag #814

r2d4 opened this issue Nov 9, 2016 · 0 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@r2d4
Copy link
Contributor

r2d4 commented Nov 9, 2016

I'm proposing that we remove the --show-libmachine-logs flag and set that behavior by a certain verbosity level --v=6. I don't think there are many situations where we want debug level minikube logs but not libmachine logs. I'm arbitrarily suggesting glog.V(6) as the cutoff for libmachine logs.

If you guys think this is a good idea, I'll go ahead and make this change eventually or someone can pick it up

@r2d4 r2d4 added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 9, 2016
@r2d4 r2d4 closed this as completed in #894 Dec 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

1 participant