Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RBAC in the example yaml file and document #61

Closed
Random-Liu opened this issue Jan 10, 2017 · 6 comments
Closed

Add RBAC in the example yaml file and document #61

Random-Liu opened this issue Jan 10, 2017 · 6 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@Random-Liu
Copy link
Member

Random-Liu commented Jan 10, 2017

Default Kubernetes setup removed ABAC support, and is only using RBAC now.
kubernetes/kubernetes#39092

This is fine for the NPD in kube-system, which has enough permission. However, the NPD setup in the example and Readme.md may not be enough.

We should add documentation and example to demonstrate how to deploy NPD in a RBAC K8s cluster.

@shyamjvs
Copy link
Member

@Random-Liu I'm going to add node-problem-detector in kubemark using RBAC as we recently moved to RBAC in kubemark as well (kubernetes/kubernetes/#39349).
Once I get it working, I'll add a link to the PR here and it would be easier for you to then prepare example/readme.

@Random-Liu
Copy link
Member Author

Cool, thanks a lot @shyamjvs

@shyamjvs
Copy link
Member

shyamjvs commented Feb 13, 2017

@Random-Liu Is this still on? If yes, here's the example for the npd role-binding (the role already exists in bootstrapping, so needn't create) -> https://github.com/kubernetes/kubernetes/blob/master/test/kubemark/resources/manifests/addons/kubemark-rbac-bindings/npd-binding.yaml
And for authenticating npd, here are the 2 things that one needs to do:

  1. Create a bearer token (that you can get by creating a serviceaccount for npd or just use default serviceaccount) or certificate or put static token in apiserver's token file (like here https://github.com/kubernetes/kubernetes/blob/master/test/kubemark/start-kubemark.sh#L90). Other authentication modes can be neglected unless required in special cases.
  2. Make npd use kubeconfig with auth token/certificate created in the above step. Like here -> https://github.com/kubernetes/kubernetes/blob/master/test/kubemark/start-kubemark.sh#L250.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 21, 2017
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle rotten
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 20, 2018
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

4 participants