Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mungebot/approval: cc only applicable approvers #2076

Closed
ixdy opened this issue Feb 28, 2017 · 4 comments
Closed

mungebot/approval: cc only applicable approvers #2076

ixdy opened this issue Feb 28, 2017 · 4 comments

Comments

@ixdy
Copy link
Member

ixdy commented Feb 28, 2017

In kubernetes/kubernetes#39678 (comment), the bot cc'd me as a suggested approver, but the only relevant directory I could approve (hack/) was already approved. pkg/ still needed approval, but I'm not an approver there.
@apelisse apelisse mentioned this issue Feb 28, 2017
Closed
24 tasks
@ixdy
Copy link
Member Author

ixdy commented Feb 28, 2017

cc @apelisse @grodrigues3

@apelisse
Copy link
Member

I think this will be fixed by #1846

@apelisse
Copy link
Member

will it @grodrigues3 ?

@apelisse apelisse mentioned this issue Mar 2, 2017
Merged
@ixdy
Copy link
Member Author

ixdy commented Mar 2, 2017

related: if a PR is already approved, don't CC any additional suggested approvers.

This was referenced Mar 7, 2017
Closed
Merged
@apelisse apelisse closed this as completed Mar 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@apelisse @ixdy