Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fix object in Kubescape generated SARIF reports when available #1183

Closed
HollowMan6 opened this issue Apr 6, 2023 · 3 comments · Fixed by #1184
Closed

Add fix object in Kubescape generated SARIF reports when available #1183

HollowMan6 opened this issue Apr 6, 2023 · 3 comments · Fixed by #1184
Assignees
Labels
feature New feature or request

Comments

@HollowMan6
Copy link
Contributor

Overview

Add the fix object in Kubescape generated SARIF reports to reflect the available fixes generated by Kubescape.

The fix object represents a proposed fix for the problem indicated by the Result. It specifies a set of artifacts to modify. For each artifact, it specifies regions to remove, and provides new content to insert.

Additional context

Although there maybe no instant benefit for this addition, hopefully there will be some in the future, as I have submitted a feature request at GitHub for supporting the fix object for their Code Scanning Tool: https://github.com/orgs/community/discussions/52156

@HollowMan6 HollowMan6 added the feature New feature or request label Apr 6, 2023
@HollowMan6 HollowMan6 self-assigned this Apr 6, 2023
@matthyx
Copy link
Contributor

matthyx commented Apr 17, 2023

Maybe we should wait until GitHub answers your feature request?
(it's a bit like chicken and egg problem)

@HollowMan6
Copy link
Contributor Author

Maybe we should wait until GitHub answers your feature request? (it's a bit like chicken and egg problem)

I think we can merge it now, as the fix object is already defined in SARIF specification. The SARIF report with fix object is still valid for GitHub Code Scanning Tool.

@craigbox
Copy link
Contributor

This will also help with GitHub Actions integration so I don't see any reason to wait!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants