Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve support for homebrew #1488

Closed
alongir opened this issue Jan 25, 2024 · 8 comments
Closed

Improve support for homebrew #1488

alongir opened this issue Jan 25, 2024 · 8 comments
Assignees

Comments

@alongir
Copy link
Member

alongir commented Jan 25, 2024

  • Install Kubeshark using Homebrew
  • If possible, enable doing so without adding a tap prior (think best-in-class homebrew app)
  • Fix the version issue
  • In the install script, identify a situation when you install via Homebrew and a version of kubeshark was already installed using the install script and state that any prior version will be deleted.
  • Do the same in the homebrew version.
@corest
Copy link
Contributor

corest commented Feb 23, 2024

  1. Fix version issue
  2. Fix install script
  3. Send PR to brew/core with kubeshark to be available without explicit tap

@corest
Copy link
Contributor

corest commented Feb 25, 2024

  1. Done

Regarding install script, I have questions

  • If kubeshark installed with homebrew and now we run install script, should it:
  1. only inform user about kubeshark existing installation
  2. inform AND delete existing installation before proceeding (like do actual brew uninstalll)
  • If kubeshark installed with install script and now we run brew install, should it:
  1. only inform user about kubeshark existing installation
  2. inform AND delete existing installation before proceeding (removing binary with rm)

@alongir

@alongir
Copy link
Member Author

alongir commented Feb 25, 2024

Inform AND delete. In both cases.

@corest
Copy link
Contributor

corest commented Feb 26, 2024

@alongir in installation script it is possible to do "brew uninstall kubeshark" -> PR here #1503

But it is not possible vice versa.
If brew runs rm for file created by installation script - it fails due to that file created with sudo.
And sudo is not allowed to be used in brew formulae.

Should we proceed then only with removing kubeshark for case when we install with script?
Because I'd rather keep it informative in both cases, then removing in one and failing in another

@corest
Copy link
Contributor

corest commented Feb 29, 2024

@SMillerDev
Copy link

You probably want these for automated bumps instead of reinventing the wheel:
https://github.com/marketplace/actions/bump-homebrew-formula or https://github.com/marketplace/actions/homebrew-bump-formula

@corest
Copy link
Contributor

corest commented Feb 29, 2024

@SMillerDev there was no plan to invent the wheel) It was just a note to not forget about it. Thank you for the links!

@corest
Copy link
Contributor

corest commented Feb 29, 2024

Ok, that took some time, but it is done now

@corest corest closed this as completed Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants