Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect status display of DevOps Projects #2591

Closed
JohnNiang opened this issue Nov 9, 2021 · 7 comments · Fixed by #2610
Closed

Incorrect status display of DevOps Projects #2591

JohnNiang opened this issue Nov 9, 2021 · 7 comments · Fixed by #2610
Assignees
@mangoGoForward
Labels
area/devops kind/bug Categorizes issue or PR as related to a bug. priority/high
Milestone
v3.2

Comments

@JohnNiang
Copy link
Member

Describe the bug

Incorrect status display of DevOps Projects. Please see the screenshot:

image

Versions used(KubeSphere/Kubernetes)
KubeSphere: v3.2.0
Kubernetes: v1.21.5

To Reproduce
Steps to reproduce the behavior:

  1. Stop Deployment devops-jenkins
  2. Create a DevOps Project
  3. See DevOps Projects

Expected behavior

When the DevOps Project is pending to synchronize, the status should be Pending instead of Active.

/area devops
/kind bug
/priority high
@JohnNiang JohnNiang added the kind/bug Categorizes issue or PR as related to a bug. label Nov 9, 2021
@JohnNiang
Copy link
Member Author

/cc @kubesphere/sig-console

@JohnNiang
Copy link
Member Author

/cc @kubesphere/sig-devops

@JohnNiang
Copy link
Member Author

JohnNiang commented Nov 15, 2021 •
edited
Loading

Exactly, we should improve the status part of CRD DevOpsProject. Just like below:

apiVersion: devops.kubesphere.io/v1alpha3
kind: DevOpsProject
metadata:
  name: project-name
spec:
staus:
  phase: Pending # Current project phase. Pending, Success or Failed

But I suggest using this temporary solution now, which uses annotation devopsproject.devops.kubesphere.io/syncstatus to display the DevOps Project status in the table before the improvement got ready.

@mangoGoForward
Copy link
Member

mangoGoForward commented Nov 15, 2021 •
edited
Loading

please assign to me.

@JohnNiang
Copy link
Member Author

/assign @mangoGoForward

@mangoGoForward mangoGoForward mentioned this issue Nov 15, 2021
Merged
@JohnNiang
Copy link
Member Author

Hi @harrisonliu5 , please help let this issue into milestone v3.2.

@harrisonliu5 harrisonliu5 modified the milestones: 3.0.0, v3.2 Nov 17, 2021
@harrisonliu5
Copy link
Collaborator

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mangoGoForward mangoGoForward

Labels
area/devops kind/bug Categorizes issue or PR as related to a bug. priority/high
Projects
None yet
Milestone
v3.2
Development

Successfully merging a pull request may close this issue.

fix: incorrect status display of DevOps Projects mangoGoForward/console
4 participants
@JohnNiang @harrisonliu5 @mangoGoForward @ks-ci-bot