Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:the associated hpa hasn't been deleted when use the command line to delete the deployment #3430

Merged
merged 1 commit into from
Jul 13, 2022

Conversation

zhaohuiweixiao
Copy link
Contributor

Signed-off-by: zhaohuihui zhaohuihui_yewu@cmss.chinamobile.com

What type of PR is this?

/kind bug

What this PR does / why we need it:

The associated hpa hasn't been deleted when use the command line to delete the deployment.
hpa删除

Special notes for reviewers:

/assign @patrick-luoyu

Does this PR introduced a user-facing change?

None

@ks-ci-bot ks-ci-bot added release-note-none kind/bug Categorizes issue or PR as related to a bug. needs-ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 12, 2022
@ks-ci-bot
Copy link
Collaborator

Hi @zhaohuiweixiao. Thanks for your PR.

I'm waiting for a kubesphere member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zhaohuiweixiao
Copy link
Contributor Author

/cc @harrisonliu5

@harrisonliu5
Copy link
Collaborator

/cc @wenxin-01

@ks-ci-bot ks-ci-bot requested a review from wenxinll July 12, 2022 09:18
@harrisonliu5 harrisonliu5 removed the request for review from wenxinll July 12, 2022 09:18
@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 12, 2022
@harrisonliu5
Copy link
Collaborator

/lgtm
/approve

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2022
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: fdfa50d4bd529ce738bf53a64b981f9ad36ec472

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harrisonliu5, zhaohuiweixiao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zhaohuiweixiao
Copy link
Contributor Author

/test pull-console-build

@ks-ci-bot
Copy link
Collaborator

@zhaohuiweixiao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-console-build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zhaohuiweixiao
Copy link
Contributor Author

zhaohuiweixiao commented Jul 12, 2022

I run the docker build successfully in local environment. Is it an environmental problem? Could you run this again? @harrisonliu5
image

…to delete the deployment

Signed-off-by: zhaohuihui <zhaohuihui_yewu@cmss.chinamobile.com>
@harrisonliu5
Copy link
Collaborator

/ok-to-test

@ks-ci-bot ks-ci-bot merged commit 092de14 into kubesphere:master Jul 13, 2022
@harrisonliu5
Copy link
Collaborator

/cherry-pick release-3.3

@ks-ci-bot
Copy link
Collaborator

@harrisonliu5: new pull request created: #3482

In response to this:

/cherry-pick release-3.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. ok-to-test release-note-none size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants