upgrade ingress nginx version

[chaunceyjiang]

What type of PR is this?

/kind bug

What this PR does / why we need it:

ingress nginx controller deployment failure due to K8s v1.22+ api removal

Which issue(s) this PR fixes:

Fixes #4548 #4486

Special notes for reviewers:

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:

upgrade ingress nginx version
https://github.com/kubernetes/ingress-nginx/blob/helm-chart-4.0.13/Changelog.md

[ks-ci-bot]

Hi @chaunceyjiang. Thanks for your PR.

I'm waiting for a kubesphere member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[pixiake]

/cc @RolandMa1986 @zryfish

[RolandMa1986]

@chaunceyjiang It seems like the nginx-ingress 1.1.0 don't compatible with the old nginx 0.48.x. We can't simply change the downloaded helm chart version.

[RolandMa1986]

@chaunceyjiang Please check the doc. in the v1.x release. we need add the following flags to let ingress controller monitoring all ingress.

In this case, you need to make your controller aware of the objects. If you have any Ingress objects that don't yet have either the .spec.ingressClassName field set in their manifest, or the ingress annotation (kubernetes.io/ingress.class), then you should start your Ingress-NGINX controller with the flag --watch-ingress-without-class=true.

You can configure your Helm chart installation's values file with .controller.watchIngressWithoutClass: true.

[chaunceyjiang]

Nginx Ingress - breaking change, Ingress.class now required

[chaunceyjiang]

@chaunceyjiang Please check the doc. in the v1.x release. we need add the following flags to let ingress controller monitoring all ingress.

In this case, you need to make your controller aware of the objects. If you have any Ingress objects that don't yet have either the .spec.ingressClassName field set in their manifest, or the ingress annotation (kubernetes.io/ingress.class), then you should start your Ingress-NGINX controller with the flag --watch-ingress-without-class=true.

You can configure your Helm chart installation's values file with .controller.watchIngressWithoutClass: true.

ok

[chaunceyjiang]

Nginx Ingress - breaking change, Ingress.class now required

Turns out the fix was very simple, you just needed to ensure that your ingress annotations included the line kubernetes.io/ingress.class: "nginx" to specify the IngressClass.

[RolandMa1986]

@chaunceyjiang if users are upgradding from an older version, all the ingresses needed to be updated manually. So it would be better to add ".controller.watchIngressWithoutClass: true" to let it works like the old way.

[chaunceyjiang]

@chaunceyjiang if users are upgradding from an older version, all the ingresses needed to be updated manually. So it would be better to add ".controller.watchIngressWithoutClass: true" to let it works like the old way.

ok
you are right . I will add the parameter flag --watch-ingress-without-class=true

[chaunceyjiang]

@chaunceyjiang if users are upgradding from an older version, all the ingresses needed to be updated manually. So it would be better to add ".controller.watchIngressWithoutClass: true" to let it works like the old way.

ok you are right . I will add the parameter flag --watch-ingress-without-class=true

[chaunceyjiang]

so kubesphere/nginx-ingress-controller:v1.1.0 is required

[chaunceyjiang]

[RolandMa1986]

/retest

[RolandMa1986]

/retest

[RolandMa1986]

/lgtm
@chaunceyjiang btw, The docker image version will be overridden by the ks-installer:
https://github.com/kubesphere/ks-installer/blob/master/roles/download/defaults/main.yml

[ks-ci-bot]

LGTM label has been added.

Git tree hash: ce4575848ac58f20b87d473f55a327ce56c267ad

[chaunceyjiang]

/lgtm @chaunceyjiang btw, The docker image version will be overridden by the ks-installer: https://github.com/kubesphere/ks-installer/blob/master/roles/download/defaults/main.yml

ok

kubesphere/ks-installer#1872

[RolandMa1986]

/cc @zryfish

[zryfish]

/approve

[ks-ci-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chaunceyjiang, zryfish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [zryfish]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[zryfish]

/test pull-kubesphere-unit-test

[ks-ci-bot]

@chaunceyjiang: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
pull-kubesphere-unit-test	a80c94e	link	/test pull-kubesphere-unit-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[zryfish]

/test pull-kubesphere-unit-test

[zryfish]

/ok-to-test