Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if AWS is supported as the provider for SMS services #140

Closed
Bennu-Li opened this issue May 12, 2022 · 14 comments · Fixed by #159
Closed

if AWS is supported as the provider for SMS services #140

Bennu-Li opened this issue May 12, 2022 · 14 comments · Fixed by #159

Comments

@Bennu-Li
Copy link
Contributor

I saw in the notification-manager documentation that the provider supports huawei, aliyun, tencent when the receiver is SMS. I would like to know if AWS is currently supported as the provider for SMS services.

https://github.com/kubesphere/notification-manager/blob/master/docs/crds/receiver.md#sms-receiver

@wanjunlei
Copy link
Collaborator

Not yet supported.

@benjaminhuo
Copy link
Member

@Bennu-Li You're welcome to create a PR to support AWS SMS

@Bennu-Li
Copy link
Contributor Author

Hi, I'd love to create a pr to support AWS SMS. But I'm not familiar with the source code for this project, and I might need some help, as well as trying to understand the amount of work required to implement this feature.

@wanjunlei
Copy link
Collaborator

Thank you for supporting our community. I will briefly introduce how to support AWS SMS.

First, you need to modify the Config CRD, and add an SMS provider of AWS. At the same time, it is necessary to add the verification of the AWS provider like this.

Second, modify the internal SMS Config.

Then, you can find the implementation of sending notifications to aliyun SMS here, you can follow this to implement sending notifications to AWS SMS.

@Bennu-Li
Copy link
Contributor Author

modify the internal SMS Config
verification of the AWS provider like this.

The description is very detailed and I already have a general understanding of how this feature is implemented.

But the link you provided for the verification of provider and the internal SMS Config are the same, I'm not sure that's it?

@wanjunlei
Copy link
Collaborator

Yes, both places need to be modified.

@wanjunlei
Copy link
Collaborator

modify the internal SMS Config
verification of the AWS provider like this.

The description is very detailed and I already have a general understanding of how this feature is implemented.

But the link you provided for the verification of provider and the internal SMS Config are the same, I'm not sure that's it?

Sorry, the second link is this

@Bennu-Li
Copy link
Contributor Author

Okay, I'll start implementing this feature this week.

@Bennu-Li
Copy link
Contributor Author

Hi, how should I quickly test the AWS Sms module I added. Is there an example of a relevant unit test, such as for Aliyun Sms?

@benjaminhuo
Copy link
Member

@zhu733756 , how did you test SMS for tecent/aliyun/huawei before?

@zhu733756
Copy link
Contributor

Add the related CRs, checking the message from SMS provider. You can also debug the process locally.

@Bennu-Li
Copy link
Contributor Author

debug the process locally.
How to debug it locally? Can you give me some details?

@zhu733756
Copy link
Contributor

If you use vscode, you can use ssh-remote plugin.

@benjaminhuo
Copy link
Member

benjaminhuo commented May 24, 2022

or use nocalhost to debug k8s apps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants