-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
if AWS is supported as the provider for SMS services #140
Comments
Not yet supported. |
@Bennu-Li You're welcome to create a PR to support AWS SMS |
Hi, I'd love to create a pr to support AWS SMS. But I'm not familiar with the source code for this project, and I might need some help, as well as trying to understand the amount of work required to implement this feature. |
Thank you for supporting our community. I will briefly introduce how to support AWS SMS. First, you need to modify the Config CRD, and add an SMS provider of AWS. At the same time, it is necessary to add the verification of the AWS provider like this. Second, modify the internal SMS Config. Then, you can find the implementation of sending notifications to aliyun SMS here, you can follow this to implement sending notifications to AWS SMS. |
The description is very detailed and I already have a general understanding of how this feature is implemented. But the link you provided for the verification of provider and the internal SMS Config are the same, I'm not sure that's it? |
Yes, both places need to be modified. |
Sorry, the second link is this |
Okay, I'll start implementing this feature this week. |
Hi, how should I quickly test the AWS Sms module I added. Is there an example of a relevant unit test, such as for Aliyun Sms? |
@zhu733756 , how did you test SMS for tecent/aliyun/huawei before? |
Add the related CRs, checking the message from SMS provider. You can also debug the process locally. |
|
If you use vscode, you can use ssh-remote plugin. |
or use nocalhost to debug k8s apps |
I saw in the notification-manager documentation that the provider supports huawei, aliyun, tencent when the receiver is SMS. I would like to know if AWS is currently supported as the provider for SMS services.
https://github.com/kubesphere/notification-manager/blob/master/docs/crds/receiver.md#sms-receiver
The text was updated successfully, but these errors were encountered: