Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate VMs with LUKS-encrypted disks from vSphere #567

Closed
TylerGillson opened this issue Aug 24, 2023 · 2 comments · Fixed by #676
Closed

Migrate VMs with LUKS-encrypted disks from vSphere #567

TylerGillson opened this issue Aug 24, 2023 · 2 comments · Fixed by #676
Assignees
Milestone

Comments

@TylerGillson
Copy link

Add support for specifying the --key flag for virt-v2v as per the virt-v2v docs:
image

Possibly via an additional option in the StorageMap CRD?

@ahadas
Copy link
Member

ahadas commented Aug 29, 2023

@TylerGillson thanks for filing this. we thought about it when trying to deal with TPM - we don't have a way to get it from RHV and even if we get it from vSphere, we won't be able to do much with that data. so asking users to specify the keys and use them this way would make sense, but if the users need to do that per-VM then it goes against the goal to ease mass migrations..

you propose to store it in the storage map because you saw a case that the keys are different for different datastores on the source environment? I'm ok with taking an assumption that the keys are not different per-VM but then I wonder if it wouldn't make more sense to set them per-plan or even per-provider

@TylerGillson
Copy link
Author

@ahadas thanks for considering it! I see your point about easing mass migrations. Putting the keys in the plan or provider makes sense to me, since multiple plans can be made if different keys exist for different datastores.

@ahadas ahadas added this to the 2.6.0 milestone Dec 6, 2023
@ahadas ahadas modified the milestones: 2.6.0, 2.7.0 Feb 15, 2024
@ahadas ahadas modified the milestones: 2.7.0, 2.6.2 May 1, 2024
@ahadas ahadas modified the milestones: 2.6.2, 2.6.3 May 15, 2024
@ahadas ahadas changed the title Support virt-v2v's --key flag for converting VMs with LUKS-encrypted disks Migrate VMs with LUKS-encrypted disks from vSphere Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants