Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] vela addon status shows more detail info. #3860

Closed
wangyikewxgm opened this issue May 11, 2022 · 7 comments · Fixed by #3876
Closed

[Feature] vela addon status shows more detail info. #3860

wangyikewxgm opened this issue May 11, 2022 · 7 comments · Fixed by #3876
Assignees
Labels
area/addon priority/nice-to-have It's a good idea, but not scheduled for any release. type/enhancement New feature or request

Comments

@wangyikewxgm
Copy link
Collaborator

wangyikewxgm commented May 11, 2022

Is your feature request related to a problem? Please describe.

The command addon status showing info is too simple which only shows the addon whether has been enabled. We can show more detail info about this addon.

Describe the solution you'd like

These info must be showed.

  1. The addon's readme witch tell user how to use this addon.
  2. All available versions of this addon.
  3. Dependency addon.
  4. Available parameter of this addon.
  5. If this addon is enabled show the setup parameter.

Describe alternatives you've considered

Additional context

@FogDong
Copy link
Member

FogDong commented May 11, 2022

Similar issue: #3856

@FogDong FogDong added type/enhancement New feature or request priority/nice-to-have It's a good idea, but not scheduled for any release. area/addon labels May 11, 2022
@wangyikewxgm
Copy link
Collaborator Author

Similar issue: #3856

Not exactly. This proposal is want to show verbose info. The solution of #3836 should change the component type and add health check for it. let the mechanism of health check in application controller to tell the status of addon.

@charlie0129
Copy link
Member

/assign

@StevenLeiZhang
Copy link
Collaborator

Is these informations covered by "status" or we need another command, such as "view", "show", to print them?

@charlie0129
Copy link
Member

Displaying the entire readme document in command line is probably hard to read.
Might just display addon description instead.

@StevenLeiZhang
Copy link
Collaborator

StevenLeiZhang commented May 12, 2022

Displaying the entire readme document in command line is probably hard to read. Might just display addon description instead.

I don't think description should be printed by 'vela addon status', because it is not status. It should be printed by 'vela addon show'

@charlie0129
Copy link
Member

charlie0129 commented May 12, 2022

I don't think description should be printed by 'vela addon status', because it is not status. It should be print by 'vela addon show'

Might also consider vela addon info, just like some widely used tools brew info or apt info.

And we can make vela addon info a synonym of vela addon status, which displays the same infomation, to provide backwards compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/addon priority/nice-to-have It's a good idea, but not scheduled for any release. type/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants