Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-resource-limits-pods rule uses limit instead of limits #52

Closed
mleneveut opened this issue Mar 16, 2021 · 2 comments
Closed

no-resource-limits-pods rule uses limit instead of limits #52

mleneveut opened this issue Mar 16, 2021 · 2 comments

Comments

@mleneveut
Copy link

Describe the bug

The no-resource-limits-pods rule uses container.resources.limit instead of container.resources.limits

To Reproduce

Steps to reproduce the behavior:

  1. Go to 'Rule Editor'
  2. Click on 'no-resource-limits-pods' rule
  3. Go to 'Rule script' tab
  4. See error

Environment Details:

  • Kubernetes Distribution/Version [e.g. GKE v1.13.12-gke.25, OpenShift 4.3] AKS v1.19.3
  • Browser [e.g. chrome, safari] Chrome
  • Version [e.g. v0.3] 0.8.15
@rubenhak
Copy link
Collaborator

rubenhak commented Mar 16, 2021

@mleneveut, ah, a typo. Thanks for posting! :)

@rubenhak
Copy link
Collaborator

rubenhak commented Mar 20, 2021

@mleneveut, fixed in version 0.9.9. Unfortunately since that is a default rule, upgrade over existing deployments wouldn't fix the rule. Any new deployments would have the correct rule. Thanks for submitting the issue.

helm upgrade --atomic -i kubevious kubevious/kubevious --version 0.9.9 -n kubevious 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants