Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

undefined: log.Context on go vet #13

Closed
RamLavi opened this issue Apr 25, 2021 · 1 comment
Closed

undefined: log.Context on go vet #13

RamLavi opened this issue Apr 25, 2021 · 1 comment

Comments

@RamLavi
Copy link

RamLavi commented Apr 25, 2021

when importing kubeivrt v0.40.0-rc.2 on KMP repo (see go mod below) with appropriate client-go, go mod tidy & vendor succeeds but then go vet fails on:

make vet
/home/ralavi/go/src/github.com/k8snetworkplumbingwg/kubemacpool/build/_output/bin//go//bin//go vet ./pkg/... ./cmd/... ./tests/...
# kubevirt.io/client-go/log
vendor/kubevirt.io/client-go/log/log.go:72:25: undefined: log.Context
vendor/kubevirt.io/client-go/log/log.go:111:26: undefined: log.NewContext
vendor/kubevirt.io/client-go/log/log.go:155:17: undefined: log.NewContext
vendor/kubevirt.io/client-go/log/log.go:160:17: undefined: log.NewContext
make: *** [Makefile:79: vet] Error 2
module github.com/k8snetworkplumbingwg/kubemacpool

go 1.15

require (
	github.com/go-logr/logr v0.3.0
	github.com/intel/multus-cni v0.0.0-20200316125841-bfaf22964b51
	github.com/mattn/goveralls v0.0.7
	github.com/onsi/ginkgo v1.15.0
	github.com/onsi/gomega v1.10.5
	github.com/pkg/errors v0.9.1
	github.com/qinqon/kube-admission-webhook v0.14.0
	github.com/spf13/pflag v1.0.5
	gomodules.xyz/jsonpatch/v2 v2.1.0
	k8s.io/api v0.20.2
	k8s.io/apimachinery v0.20.2
	k8s.io/client-go v12.0.0+incompatible
	k8s.io/code-generator v0.20.2
	kubevirt.io/client-go v0.40.0-rc.2
	kubevirt.io/kubevirt v0.40.0-rc.2
	kubevirt.io/qe-tools v0.1.6
	sigs.k8s.io/controller-runtime v0.8.2
	sigs.k8s.io/controller-tools v0.4.0
	sigs.k8s.io/kustomize/kustomize/v3 v3.3.0
)

replace (
	bitbucket.org/ww/goautoneg => github.com/munnerz/goautoneg v0.0.0-20120707110453-a547fc61f48d
	github.com/go-logr/zapr => github.com/go-logr/zapr v0.2.0
	github.com/openshift/api => github.com/openshift/api v0.0.0-20201120165435-072a4cd8ca42
	github.com/openshift/client-go => github.com/openshift/client-go v0.0.0-20200521150516-05eb9880269c
	golang.org/x/text => golang.org/x/text v0.3.3

	// Pinned to kubernetes-0.20.2
	k8s.io/api => k8s.io/api v0.20.2
	k8s.io/apiextensions-apiserver => k8s.io/apiextensions-apiserver v0.20.2
	k8s.io/apimachinery => k8s.io/apimachinery v0.20.2
	k8s.io/apiserver => k8s.io/apiserver v0.20.2
	k8s.io/cli-runtime => k8s.io/cli-runtime v0.20.2
	k8s.io/client-go => k8s.io/client-go v0.20.2
	k8s.io/cloud-provider => k8s.io/cloud-provider v0.20.2
	k8s.io/cluster-bootstrap => k8s.io/cluster-bootstrap v0.20.2
	k8s.io/component-base => k8s.io/component-base v0.20.2
	k8s.io/cri-api => k8s.io/cri-api v0.20.2
	k8s.io/csi-translation-lib => k8s.io/csi-translation-lib v0.20.2
	k8s.io/kube-aggregator => k8s.io/kube-aggregator v0.20.2
	k8s.io/kube-controller-manager => k8s.io/kube-controller-manager v0.20.2
	k8s.io/kube-proxy => k8s.io/kube-proxy v0.20.2
	k8s.io/kube-scheduler => k8s.io/kube-scheduler v0.20.2
	k8s.io/kubelet => k8s.io/kubelet v0.20.2
	k8s.io/legacy-cloud-providers => k8s.io/legacy-cloud-providers v0.20.2
	k8s.io/metrics => k8s.io/metrics v0.20.2
	k8s.io/sample-apiserver => k8s.io/sample-apiserver v0.20.2

	kubevirt.io/client-go => kubevirt.io/client-go v0.40.0-rc.2
	sigs.k8s.io/structured-merge-diff => sigs.k8s.io/structured-merge-diff v1.0.2
)

also tried v0.40.0, had no luck..
issue looks related to former issue but I didn't find something useful there.

@RamLavi
Copy link
Author

RamLavi commented Apr 26, 2021

solved it by using the same log replace that kubevirt is currently using.

replace github.com/go-kit/kit => github.com/go-kit/kit v0.3.0

closing issue

@RamLavi RamLavi closed this as completed Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant